From: Sohil Mehta <sohil.mehta@intel.com>
To: Dave Hansen <dave.hansen@intel.com>,
Andy Lutomirski <luto@kernel.org>,
the arch/x86 maintainers <x86@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>
Cc: Jonathan Corbet <corbet@lwn.net>,
"H. Peter Anvin" <hpa@zytor.com>,
"Josh Poimboeuf" <jpoimboe@kernel.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Ard Biesheuvel <ardb@kernel.org>,
"Kirill A . Shutemov" <kas@kernel.org>, Xin Li <xin@zytor.com>,
David Woodhouse <dwmw@amazon.co.uk>,
Sean Christopherson <seanjc@google.com>,
"Rick P Edgecombe" <rick.p.edgecombe@intel.com>,
Vegard Nossum <vegard.nossum@oracle.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
"Randy Dunlap" <rdunlap@infradead.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Kees Cook <kees@kernel.org>, Tony Luck <tony.luck@intel.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
<linux-doc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
<linux-efi@vger.kernel.org>
Subject: Re: [PATCH v11 5/9] x86/efi: Disable LASS while mapping the EFI runtime services
Date: Fri, 31 Oct 2025 11:03:14 -0700 [thread overview]
Message-ID: <efd6ec82-5576-41f1-a244-2f80d72e93e4@intel.com> (raw)
In-Reply-To: <6dec8398-3f7c-44db-a30d-33593af0217f@intel.com>
On 10/31/2025 10:41 AM, Dave Hansen wrote:
> On 10/31/25 10:38, Andy Lutomirski wrote:
>> Am I imagining an issue that doesn’t exist? Is there some way to be
>> reasonably convinced that you haven’t missed another EFI code path?
>> Would it be ridiculous to defer enabling LASS until we’re almost
>> ready to run user code?
> Deferring is a good idea. I was just asking for the same thing for the
> CR pinning enforcement. The earlier we try to do these things, the more
> we just trip over ourselves.
I had suggested deferring as well to Kirill when I was reviewing the
series. He preferred to enable LASS with other similar features such as
SMAP, SMEP.
One other thing to consider:
Doing it in identify_cpu() makes it easy for all the APs to program
their CR4.LASS bit. If we were to defer it, we would need some
additional work to setup all the APs.
Do we already do this for something else? That would make it easier to
tag along.
next prev parent reply other threads:[~2025-10-31 18:03 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 21:03 [PATCH v11 0/9] x86: Enable Linear Address Space Separation support Sohil Mehta
2025-10-29 21:03 ` [PATCH v11 1/9] x86/cpufeatures: Enumerate the LASS feature bits Sohil Mehta
2025-10-31 17:03 ` Dave Hansen
2025-10-29 21:03 ` [PATCH v11 2/9] x86/cpu: Add an LASS dependency on SMAP Sohil Mehta
2025-10-31 17:04 ` Dave Hansen
2025-10-29 21:03 ` [PATCH v11 3/9] x86/asm: Introduce inline memcpy and memset Sohil Mehta
2025-10-31 17:06 ` Dave Hansen
2025-10-29 21:03 ` [PATCH v11 4/9] x86/alternatives: Disable LASS when patching kernel code Sohil Mehta
2025-10-31 17:10 ` Dave Hansen
2025-11-10 18:15 ` Sohil Mehta
2025-11-10 19:09 ` H. Peter Anvin
2025-11-10 19:24 ` Borislav Petkov
2025-11-12 13:56 ` Ard Biesheuvel
2025-11-12 14:51 ` Dave Hansen
2025-11-12 14:57 ` H. Peter Anvin
2025-11-12 15:18 ` Ard Biesheuvel
2025-11-12 15:23 ` H. Peter Anvin
2025-11-12 15:28 ` Ard Biesheuvel
2025-11-12 15:47 ` H. Peter Anvin
2025-11-12 16:18 ` Sohil Mehta
2025-11-12 16:26 ` H. Peter Anvin
2025-11-12 16:29 ` H. Peter Anvin
2025-10-29 21:03 ` [PATCH v11 5/9] x86/efi: Disable LASS while mapping the EFI runtime services Sohil Mehta
2025-10-31 17:11 ` Dave Hansen
2025-10-31 17:38 ` Andy Lutomirski
2025-10-31 17:41 ` Dave Hansen
2025-10-31 18:03 ` Sohil Mehta [this message]
2025-10-31 18:12 ` Dave Hansen
2025-11-07 9:04 ` Peter Zijlstra
2025-11-07 9:22 ` Ard Biesheuvel
2025-11-07 9:27 ` H. Peter Anvin
2025-11-07 9:35 ` Ard Biesheuvel
2025-11-07 9:40 ` Peter Zijlstra
2025-11-07 10:09 ` Ard Biesheuvel
2025-11-07 10:27 ` Peter Zijlstra
2025-11-08 0:48 ` Andy Lutomirski
2025-11-08 16:18 ` H. Peter Anvin
2025-11-08 22:50 ` H. Peter Anvin
2025-11-07 10:10 ` Peter Zijlstra
2025-11-07 10:17 ` Ard Biesheuvel
2025-10-31 19:04 ` Sohil Mehta
2025-11-07 7:36 ` Sohil Mehta
2025-10-31 18:32 ` Sohil Mehta
2025-10-29 21:03 ` [PATCH v11 6/9] x86/kexec: Disable LASS during relocate kernel Sohil Mehta
2025-10-31 17:14 ` Dave Hansen
2025-10-29 21:03 ` [PATCH v11 7/9] x86/traps: Communicate a LASS violation in #GP message Sohil Mehta
2025-10-31 17:16 ` Dave Hansen
2025-10-31 19:59 ` Sohil Mehta
2025-10-31 20:03 ` Andy Lutomirski
2025-10-31 20:56 ` Dave Hansen
2025-10-29 21:03 ` [PATCH v11 8/9] selftests/x86: Update the negative vsyscall tests to expect a #GP Sohil Mehta
2025-10-31 17:20 ` Dave Hansen
2025-10-29 21:03 ` [PATCH v11 9/9] x86/cpu: Enable LASS by default during CPU initialization Sohil Mehta
2025-10-30 8:40 ` H. Peter Anvin
2025-10-30 15:45 ` Andy Lutomirski
2025-10-30 16:44 ` Sohil Mehta
2025-10-30 16:53 ` Andy Lutomirski
2025-10-30 17:24 ` Sohil Mehta
2025-10-30 17:31 ` Andy Lutomirski
2025-10-30 21:13 ` David Laight
2025-10-31 6:41 ` H. Peter Anvin
2025-10-31 16:55 ` Dave Hansen
2025-10-30 16:27 ` Dave Hansen
2025-11-07 8:01 ` H. Peter Anvin
2025-11-07 20:08 ` Sohil Mehta
2025-10-31 17:21 ` Dave Hansen
2025-10-31 20:04 ` Sohil Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efd6ec82-5576-41f1-a244-2f80d72e93e4@intel.com \
--to=sohil.mehta@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dwmw@amazon.co.uk \
--cc=geert@linux-m68k.org \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=kas@kernel.org \
--cc=kees@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vegard.nossum@oracle.com \
--cc=x86@kernel.org \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).