Re: [PATCH 7/8] lib: overflow: update reference to kunit-tool

Daniel Latypov
2022-08-22T22:52:44Z

On Mon, Aug 22, 2022 at 3:35 PM Tales <tales.aparecida@gmail.com> wrote:
>
> Hi Daniel,
>
> Em seg., 22 de ago. de 2022 às 17:09, Daniel Latypov
> <dlatypov@google.com> escreveu:
> >
> > On Thu, Aug 18, 2022 at 10:33 PM Tales Aparecida
> > <tales.aparecida@gmail.com> wrote:
> > >
> > > Replace URL with an updated path to the full Documentation page
> > >
> > > Signed-off-by: Tales Aparecida <tales.aparecida@gmail.com>
> > > ---
> > > lib/overflow_kunit.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/lib/overflow_kunit.c b/lib/overflow_kunit.c
> > > index 7e3e43679b73..78075106c0df 100644
> > > --- a/lib/overflow_kunit.c
> > > +++ b/lib/overflow_kunit.c
> > > @@ -1,7 +1,7 @@
> > > // SPDX-License-Identifier: GPL-2.0 OR MIT
> > > /*
> > > * Test cases for arithmetic overflow checks. See:
> > > - * https://www.kernel.org/doc/html/latest/dev-tools/kunit/kunit-tool.html#configuring-building-and-running-tests
> > > + * "Running tests with kunit_tool" at Documentation/dev-tools/kunit/start.rst
> >
> > Oh, I thought I had sent a patch out for this.
> > The rewritten version of the patch is
> > https://www.kernel.org/doc/html/latest/dev-tools/kunit/run_wrapper.html
> > That's what I was intending to rewrite this line to point to.
> >
> > But if people like a Documentation/ path to start.rst instead, that also works.
> >
> > Daniel
>
> You are absolutely right! You did send and I wasn't aware, sorry.
> https://lore.kernel.org/all/20220603195626.121922-1-dlatypov@google.com/
> I guess it stalled after that discussion about *where* it should be applied,
> I got a green flag in IRC and didn't do my due diligence carefully,
> just tried to find pending patches at linux-kselftest which wasn't
> CC'd

Oh right, it was that series where I didn't cc linux-kselftest.
That was my bad, sorry.

But I had forgotten to include a patch in that series to update this
file still, afaict.
I could revive that series and add on a version of this patch, if we want?

Daniel