From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44DC63290BA; Wed, 11 Mar 2026 02:58:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.187 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773197893; cv=none; b=nuZGmSUd6C1iCmwcaebMDENzlg39ch7OBkSd/Z3NZCl0MAq9Dqt1a0xAH08kslniDL6gti92s/4KNm9iyF+ozU8dvkWmGVIqTHOZYW3ZTRvLNfFsKEnIuPSlOAtYApgaeAsLgtsuvAgBDuvpGGSOdK0jiq0BB06dy7n7wN2kzaA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773197893; c=relaxed/simple; bh=NjpOQrpdsn8Fx7BCpaR7E9HghxFuVi8WOv3Lb3TklfU=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=Syp8lU6y6zC05Dbh2czqI906zui4Z4av7qwlXz0nptGkfaCuc5pDk1Lid2BcgHAOk8ilRUcwQhpU6NXOj5TuIGgxZ094bJesO9zkn+FfsefTaNMFGacXu/xHpjG+Y2DafgU22MaYxrTxGcglz3qpoNn6lerNzA3myy1ToCgYt64= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=OIFuDbC2; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=OIFuDbC2; arc=none smtp.client-ip=45.249.212.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="OIFuDbC2"; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="OIFuDbC2" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=b36C7PXQWMtROHC3akP80A02jao7I70/cN0HO+5yrzc=; b=OIFuDbC2xS7Rgm+I36JhjfBBuNlrExfOc4b/6nZu5Eci5l3+fQS/kU6c0nfyQEGA12kX/Y7Hm Q4fnrBYIxytCYBOb9gfPVNmdxJt8Tvf2GHBr2Fdo4Eecx+kEiQ1JtKfbeg5YZs6XhpMHGRf3AdS dsh0tpvrdex5MaKPf2KuYUQ= Received: from canpmsgout05.his.huawei.com (unknown [172.19.92.145]) by szxga01-in.huawei.com (SkyGuard) with ESMTPS id 4fVwQT2ZJ0z1BFwD; Wed, 11 Mar 2026 10:57:21 +0800 (CST) dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=b36C7PXQWMtROHC3akP80A02jao7I70/cN0HO+5yrzc=; b=OIFuDbC2xS7Rgm+I36JhjfBBuNlrExfOc4b/6nZu5Eci5l3+fQS/kU6c0nfyQEGA12kX/Y7Hm Q4fnrBYIxytCYBOb9gfPVNmdxJt8Tvf2GHBr2Fdo4Eecx+kEiQ1JtKfbeg5YZs6XhpMHGRf3AdS dsh0tpvrdex5MaKPf2KuYUQ= Received: from mail.maildlp.com (unknown [172.19.162.140]) by canpmsgout05.his.huawei.com (SkyGuard) with ESMTPS id 4fVwJc46ySz12LFG; Wed, 11 Mar 2026 10:52:16 +0800 (CST) Received: from kwepemk500009.china.huawei.com (unknown [7.202.194.94]) by mail.maildlp.com (Postfix) with ESMTPS id 2B67A2012A; Wed, 11 Mar 2026 10:57:52 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by kwepemk500009.china.huawei.com (7.202.194.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 11 Mar 2026 10:57:50 +0800 Message-ID: Date: Wed, 11 Mar 2026 10:57:49 +0800 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/2] ACPI: Rename get_acpi_id_for_cpu() to acpi_get_cpu_acpi_id() on non-x86 To: Bjorn Helgaas CC: Bjorn Helgaas , Catalin Marinas , Will Deacon , "Rafael J . Wysocki" , Jonathan Corbet , Shuah Khan , Huacai Chen , WANG Xuerui , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H . Peter Anvin" , Juergen Gross , Boris Ostrovsky , Len Brown , Sunil V L , Mark Rutland , Jonathan Cameron , Kees Cook , Yanteng Si , Sean Christopherson , Kai Huang , Tom Lendacky , Thomas Huth , Thorsten Blum , Kevin Loughlin , Zheyun Shen , Peter Zijlstra , Pawan Gupta , Xin Li , "Ahmed S . Darwish" , Sohil Mehta , Ilkka Koskinen , Robin Murphy , James Clark , Besar Wicaksono , Ma Ke , Ajit Khaparde , Wei Huang , Andy Gospodarek , Somnath Kotur , , , , , , , , , , , , , References: <20260310175305.GA730372@bhelgaas> Content-Language: en-US From: fengchengwen In-Reply-To: <20260310175305.GA730372@bhelgaas> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: kwepems500001.china.huawei.com (7.221.188.70) To kwepemk500009.china.huawei.com (7.202.194.94) On 3/11/2026 1:53 AM, Bjorn Helgaas wrote: > On Tue, Mar 10, 2026 at 11:20:48AM +0800, Chengwen Feng wrote: >> To unify the CPU ACPI ID retrieval interface across architectures, >> rename the existing get_acpi_id_for_cpu() function to >> acpi_get_cpu_acpi_id() on arm64/riscv/loongarch platforms. >> >> This is a pure rename with no functional change, preparing for a >> consistent ACPI Processor UID retrieval interface across all ACPI-enabled >> platforms. > > Really a question for the ACPI folks, but my preferences would be: > > - Simpler name for the interface, e.g., "acpi_get_cpu_id()" OK, and how about add u-, like: acpi_get_cpu_uid() > > - Single prototype in generic header, e.g., include/linux/acpi.h OK > > - Split the x86 part to a separate patch and maybe (a tangent, but > looks dubious to me) figure out whether/why xen needs xen_vcpu_id > to be ACPI CPU IDs OK for a separate patch for x86. Btw: the x86 implementation in 2/2 commit may has problem, please see the reply in 2/2 for detail. > >> Cc: stable@vger.kernel.org >> Signed-off-by: Chengwen Feng >> Reviewed-by: Jonathan Cameron >> --- >> arch/arm64/include/asm/acpi.h | 4 ++-- >> arch/loongarch/include/asm/acpi.h | 2 +- >> arch/riscv/include/asm/acpi.h | 2 +- >> arch/riscv/kernel/acpi_numa.c | 2 +- >> drivers/acpi/pptt.c | 16 ++++++++-------- >> drivers/acpi/riscv/rhct.c | 2 +- >> drivers/perf/arm_cspmu/arm_cspmu.c | 2 +- >> 7 files changed, 15 insertions(+), 15 deletions(-) >