From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 958A1C4741F for ; Fri, 25 Sep 2020 23:06:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C15D21D91 for ; Fri, 25 Sep 2020 23:06:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601075170; bh=QxoSfI6uLVfikSdXGH4EFLGndRgkR+zRuuSIqIEhjcY=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=z4dn3IsL/7BzaAfOn5OKBNLGKMcxyQHvyoCS2w66jIDM9ZSGPPfCYL1yxbvrMNoA3 F+XnBLFzvao0gmKuUj8oHGLXVOvKWSVbxy6VJPNaQ03EegP4JMrFX7ozEpXPIugK6U 5DA69eG+47e3QjZNhe1NnMYY0eq15SKDsTXv6VFA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729302AbgIYXGH (ORCPT ); Fri, 25 Sep 2020 19:06:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729287AbgIYXGG (ORCPT ); Fri, 25 Sep 2020 19:06:06 -0400 Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A0FFC0613D4 for ; Fri, 25 Sep 2020 16:06:06 -0700 (PDT) Received: by mail-oi1-x229.google.com with SMTP id i17so4451882oig.10 for ; Fri, 25 Sep 2020 16:06:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=76AVeLPThqJyq9xRW6clpHIRKAOCQwmI85cgL3Cyres=; b=c+XpSxQO/nxlyT0ft4XZzdREUsZN6qokIzkZCdfBlxYsfnKoDcsMJJ9R5g4+Qi8D+p gSLotVkVSfHXVSAXrZMhoIhhcDe0Lkxo/ye47mROh45ZpOWSOW1FHnGe2RuIUda9iVXy W4gjczoxcJKDDxiloVI1ZfzdGNVBkcFaAIUSw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=76AVeLPThqJyq9xRW6clpHIRKAOCQwmI85cgL3Cyres=; b=T1GVm4rsiiZV6QLVeo90HuxUirZ8DEv/X6AkN2TdVezIBghA/esonWUrTj9PDhYInn WKgWEFM+coEPwL83DjiRPqJ/d5Ol3/RUiqANmi18UcuAql+7/ebizgG/FoVOCwznqdYn whuVbDA3UNMT5YUn4oM/Y5lat6ng66Ah/3AQHCJms9nyedPPX1dT83IDeroZmF9UA3Zq ++Vmh51ad7VaqlmN0NurCxofdDcyz55X8TMDSFKqOZs5Z6FrWcI9oTZQyKCIEndPfINM 0QLGAZnVWoM+Jd8GoDo06Q78jM9++Sz++Jk1VOjgMqmTANky3Psuw5Y54pyFh5+CXfkK amIQ== X-Gm-Message-State: AOAM530CmkdzWShXs0DQjE/G6KxWMEOAxdxsMVcSruda6mbAHO1bYI+Q pI3qaXmX+ZkC06I1W05+Rxg8Nw== X-Google-Smtp-Source: ABdhPJyWna6d5P8FvJbM90Pt7OdJcvYVRXH0ouob2XpQcut86to6eu59wT9/3fQh+R4sVTzQdTqGSg== X-Received: by 2002:a05:6808:996:: with SMTP id a22mr483988oic.109.1601075165095; Fri, 25 Sep 2020 16:06:05 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id 74sm996786otc.65.2020.09.25.16.06.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Sep 2020 16:06:04 -0700 (PDT) Subject: Re: [PATCHv5 kselftest next] selftests/run_kselftest.sh: make each test individually selectable To: Kees Cook , Shuah Khan , Naresh Kamboju Cc: Hangbin Liu , "open list:KERNEL SELFTEST FRAMEWORK" , Jonathan Corbet , linux-doc@vger.kernel.org, open list , Tim.Bird@sony.com, lkft-triage@lists.linaro.org, Anders Roxell , Justin Cook , Linux-Next Mailing List , Shuah Khan References: <20200914021758.420874-1-liuhangbin@gmail.com/> <20200914022227.437143-1-liuhangbin@gmail.com> <202009251414.15274C0@keescook> From: Shuah Khan Message-ID: Date: Fri, 25 Sep 2020 17:06:02 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <202009251414.15274C0@keescook> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 9/25/20 3:16 PM, Kees Cook wrote: > On Fri, Sep 25, 2020 at 01:51:53PM +0530, Naresh Kamboju wrote: >> On Mon, 14 Sep 2020 at 07:53, Hangbin Liu wrote: >>> >>> Currently, after generating run_kselftest.sh, there is no way to choose >>> which test we could run. All the tests are listed together and we have >>> to run all every time. This patch enhanced the run_kselftest.sh to make >>> the tests individually selectable. e.g. >>> >>> $ ./run_kselftest.sh -t "bpf size timers" >> >> My test run break on linux next >> >> ./run_kselftest.sh: line 1331: syntax error near unexpected token `)' >> ./run_kselftest.sh: line 1331: `-e -s | --summary ) >> logfile=$BASE_DIR/output.log; cat /dev/null > $logfile; shift ;;' > > Yes, please revert this patch. The resulting script is completely > trashed: > Thank you both. Now reverted. thanks, -- Shuah