Linux Documentation
 help / color / mirror / Atom feed
From: David Lechner <dlechner@baylibre.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Marcelo Schmitt <marcelo.schmitt@analog.com>,
	linux-iio@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, lars@metafoo.de, corbet@lwn.net,
	marcelo.schmitt1@gmail.com
Subject: Re: [PATCH v2 1/1] Documentation: iio: Add ADC documentation
Date: Sat, 18 Jan 2025 11:03:26 -0600	[thread overview]
Message-ID: <f3c1f7d2-3cc7-43b0-a166-e2053b2dabfa@baylibre.com> (raw)
In-Reply-To: <20250118155153.2574dbe5@jic23-huawei>

On 1/18/25 9:51 AM, Jonathan Cameron wrote:
> On Wed, 15 Jan 2025 11:23:24 -0600
> David Lechner <dlechner@baylibre.com> wrote:
> 
>> On 1/14/25 7:53 AM, Marcelo Schmitt wrote:

...

>>> +1.2.2 Differential Unipolar Channels
>>> +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>> +
>>> +For **differential unipolar** channels, the analog voltage at the positive input
>>> +must also be higher than the voltage at the negative input. Thus, the actual
>>> +input range allowed to a differential unipolar channel is IN- to +VREF. Because
>>> +IN+ is allowed to swing with the measured analog signal and the input setup must
>>> +guarantee IN+ will not go below IN- (nor IN- will raise above IN+), most
>>> +differential unipolar channel setups have IN- fixed to a known voltage that does
>>> +not fall within the voltage range expected for the measured signal. This leads
>>> +to a setup that is equivalent to a pseudo-differential channel. Thus,
>>> +differential unipolar channels are actually pseudo-differential unipolar
>>> +channels.  
>>
>> I don't think this is equivalent to pseudo-differential unipolar. That one has
>> a common mode voltage supply on the negative input. This one has a full range
>> signal on the negative input. This is the diagram I was expecting here.
>>
>> ::
>>
>>   -------- VREF -------
>>     ´ `       ´ `               +-------------------+
>>   /     \   /     \   /        /                    |
>>          `-´       `-´    --- <  IN+                |
>>   ------ GND (0V) -----        |                    |
>>                                |            ADC     |
>>   -------- VREF -------        |                    |
>>         ´ `       ´ `     --- <  IN-                |
>>   \   /     \   /     \        \       VREF         |
>>    `-´       `-´                +-------------------+
>>   ------ GND (0V) -----                  ^        
>>                                          |       
>>                                   External VREF
> 
> If it's unipolar, output must be positive which isn't true here.
> Do we actually see differential unipolar except for the pseudo case with
> common mode voltage?   Seems like a weird device.

OK, it sounds like you and Marcelo are considering bipolar to mean that the
difference is bipolar rather than the inputs. In that case, it doesn't seem like
there would ever be such a thing as unipolar (true) differential.

I was looking at this from the point of view of only the inputs and not the
difference. I'm seeing that the input voltage can only be positive, so to me
that would be unipolar.

So at the very beginning, when we first mention unipolar and bipolar, it would
be helpful to add a bit making it clear exactly which point in the system we
are talking about, the input or the output.






  reply	other threads:[~2025-01-18 17:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-14 13:53 [PATCH v2 1/1] Documentation: iio: Add ADC documentation Marcelo Schmitt
2025-01-15 17:23 ` David Lechner
2025-01-18 15:51   ` Jonathan Cameron
2025-01-18 17:03     ` David Lechner [this message]
2025-01-18 17:35       ` Jonathan Cameron
2025-01-18 20:51     ` Marcelo Schmitt
2025-01-25 12:04       ` Jonathan Cameron
2025-01-18 20:18   ` Marcelo Schmitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3c1f7d2-3cc7-43b0-a166-e2053b2dabfa@baylibre.com \
    --to=dlechner@baylibre.com \
    --cc=corbet@lwn.net \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.schmitt1@gmail.com \
    --cc=marcelo.schmitt@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox