From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793173662; b=471prQqFV8pjSdq7Wo6WW45YFFQfkmnUZvUDxlwOhPVHx/i0kcD3SsBFVj1twsPwPxYL 44sjfmURfC8p9SNhcAtjYmAPBAhO2s5zmLOeEdg5TUkPWT7WouRwc742biiwiPdf18fvg m/Ng2vDBPy4yylmu/br3nD5rHeEmiDIK8pXnhvCFOQCWq5aUylVlz3LW1Weuj6KwMP7Yo rqcqQPiaEEnvjpfH6XrFyme6e1UqSKB0MuyAH8bEirb0tijN5W/zVbNZGKVdePrGNUc6j 20tIv98onsOksNyjh+KwN/6AWxA8hsbYc+tzAAyCec7G30/lAUoKMOX2Q8QBMYA9vLQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793173662; h=DMARC-Filter:Received:DKIM-Signature:DKIM-Signature:DKIM-Signature: DKIM-Signature:Received:Received:Message-ID:Date:MIME-Version: User-Agent:Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding:X-Spam-Flag:X-Spam-Level: X-Spamd-Result:X-Spam-Score; bh=AuAv2eYPoMaDiX95eQHdX4lkmF9eQuCjw5mck6WOBR4=; b=x2uxlLXX2WGs96qoR/1taDOjNUeUVRQhOiicloKS7QjZ7YcYFRM+2zMvz68N+pdA/RhL IoTpgb7fSZPioL1OI319oQClXcrGchZWq1ZF/IH0F2ccPbAZyn+H6UaaZ5Qmbgsh0xc92 NOUPbqlF6+3UaegFK9/3IWeRs4fOpOgS0SjX1AMsuuoLGnc7PEAdDzrksrUs4PPKB3KaW QwfPYjvhe+5L5WbPVP57RLUY7DHzBeSAqtGyAxugO2Z7hCuni0Olte6rPBGis2iA5cQaQ 2AtQY289N2hgg5OCkDNKeSFtEo9Lw1tNYRyYZZ1QaO/Rt+k0Tp1H023moLMJmc5/O0Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=RjgAH1HD; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=v6oD0L1W; dkim=pass header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=RjgAH1HD; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=v6oD0L1W; arc=none smtp.remote-ip=195.135.223.130 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC31E606A31A; Wed, 28 Oct 2026 07:47:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org BC31E606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=RjgAH1HD; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=v6oD0L1W; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=RjgAH1HD; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=v6oD0L1W Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0523C22117; Wed, 28 Oct 2026 07:47:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1793173660; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AuAv2eYPoMaDiX95eQHdX4lkmF9eQuCjw5mck6WOBR4=; b=RjgAH1HDC/B870RWG0V2P7cQe4kWercx/7wdbVAvXc3ksy5Eikwea8Jroh6KS21YGR5nMX ol8+xNxJ53882viH/Cep2etKR54YuUMQjl35QsiqxdT+W/7pa/MXhNTl1NdWpSNAoEDAzJ PjWcdWPhorTsFXh9OvnarYZ5VIp2uV8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1793173660; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AuAv2eYPoMaDiX95eQHdX4lkmF9eQuCjw5mck6WOBR4=; b=v6oD0L1WZjDPXrrNYwvqHafspqBdpHEIcN2GE7aOEDvFdZ/QuBb+2c362FF8DJthHoa4sy CiFXrm/qsmWEzlBQ== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1793173660; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AuAv2eYPoMaDiX95eQHdX4lkmF9eQuCjw5mck6WOBR4=; b=RjgAH1HDC/B870RWG0V2P7cQe4kWercx/7wdbVAvXc3ksy5Eikwea8Jroh6KS21YGR5nMX ol8+xNxJ53882viH/Cep2etKR54YuUMQjl35QsiqxdT+W/7pa/MXhNTl1NdWpSNAoEDAzJ PjWcdWPhorTsFXh9OvnarYZ5VIp2uV8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1793173660; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AuAv2eYPoMaDiX95eQHdX4lkmF9eQuCjw5mck6WOBR4=; b=v6oD0L1WZjDPXrrNYwvqHafspqBdpHEIcN2GE7aOEDvFdZ/QuBb+2c362FF8DJthHoa4sy CiFXrm/qsmWEzlBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 622511321C; Wed, 28 Oct 2026 07:47:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 8GAICJuo4WoRVAAAD6G6ig (envelope-from ); Wed, 28 Oct 2026 07:47:39 +0000 Message-ID: Date: Wed, 28 Oct 2026 08:47:38 +0100 X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] nvme-tcp: validate the TLS handshake timeout To: Yingjie Wang <1075151112@qq.com>, linux-nvme@lists.infradead.org Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, kch@nvidia.com, corbet@lwn.net, skhan@linuxfoundation.org, rdunlap@infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: Content-Language: en-US From: Hannes Reinecke In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Flag: NO X-Spam-Level: X-Spamd-Result: default: False [-13.29 / 50.00]; SUSE_INTERNAL_BYPASS(-9.00)[]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; FREEMAIL_TO(0.00)[qq.com,lists.infradead.org]; RCPT_COUNT_TWELVE(0.00)[12]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_ENVRCPT(0.00)[qq.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,imap1.dmz-prg2.suse.org:helo,qq.com:email] X-Spam-Score: -13.29 On 10/27/26 1:13 PM, Yingjie Wang wrote: > tls_handshake_timeout is writable but stored as a signed int. Multiplying > the value by MSEC_PER_SEC and HZ therefore uses signed arithmetic. > > With HZ=1000, setting it to 2147484 overflows both multiplications. If > the handshake request is accepted and its completion remains pending, > schedule_timeout() reports a wrong timeout value with a stack dump and > returns zero. The handshake then fails immediately with -ETIMEDOUT, > while the handshake agent was given about 24.9 days. Negative values > such as -1 have the same kernel-side effect. > > Store the parameter as an unsigned int and reject values that cannot be > represented both by tls_handshake_args::ta_timeout_ms and by a safe > jiffies delay. Take one snapshot so a concurrent parameter update cannot > give the handshake agent and completion wait different timeouts. > Document the accepted range for built-in use. > > wait_for_completion_interruptible_timeout() returns the remaining > jiffies as a long after a successful completion. Keep that result in a > long because an accepted timeout can exceed INT_MAX jiffies on 64-bit > systems. > > Negative and oversized values now fail with -EINVAL. Keep zero valid, > preserving the existing immediate-timeout behavior. > > Fixes: be8e82caa685 ("nvme-tcp: enable TLS handshake upcall") > Cc: stable@vger.kernel.org > Signed-off-by: Yingjie Wang <1075151112@qq.com> > --- > .../admin-guide/kernel-parameters.txt | 5 +++ > drivers/nvme/host/tcp.c | 34 ++++++++++++++----- > 2 files changed, 31 insertions(+), 8 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich