From: Krzysztof Kozlowski <krzk@kernel.org>
To: tzuhao.wtmh@gmail.com, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Jonathan Corbet" <corbet@lwn.net>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Naresh Solanki" <naresh.solanki@9elements.com>,
"Fabio Estevam" <festevam@gmail.com>,
"Michal Simek" <michal.simek@amd.com>,
"Rodrigo Gobbi" <rodrigo.gobbi.7@gmail.com>,
"Henry Wu" <Henry_Wu@quantatw.com>,
"Grant Peltier" <grantpeltier93@gmail.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Cedric Encarnacion" <cedricjustine.encarnacion@analog.com>,
"John Erasmus Mari Geronimo"
<johnerasmusmari.geronimo@analog.com>,
"Noah Wang" <noahwang.wang@outlook.com>,
"Ninad Palsule" <ninad@linux.ibm.com>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Leo Yang" <leo.yang.sy0@gmail.com>,
"Mariel Tinaco" <Mariel.Tinaco@analog.com>,
"Alex Vdovydchenko" <xzeol@yahoo.com>,
"Kim Seer Paller" <kimseer.paller@analog.com>,
"Nuno Sa" <nuno.sa@analog.com>,
"Thomas Weißschuh" <linux@weissschuh.net>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: trivial-devices: Add mp2869a/mp29612a device entry
Date: Tue, 24 Jun 2025 09:44:35 +0200 [thread overview]
Message-ID: <f4f45fbd-2929-491c-8f5e-413b9c481259@kernel.org> (raw)
In-Reply-To: <20250624074156.291176-2-Henry_Wu@quantatw.tw>
On 24/06/2025 09:41, tzuhao.wtmh@gmail.com wrote:
> From: Henry Wu <Henry_Wu@quantatw.com>
>
> Add trivial-devices binding for mp2869a/mp29612a to enable automatic matching
> in device tree.
Drop "enable automatic ...." - this is not what is being done here.
Instead describe the hardware.
Please organize the patch documenting compatible (DT bindings) before
their user.
See also:
https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46
>
> Signed-off-by: Henry Wu <Henry_Wu@quantatw.com>
> ---
> Documentation/devicetree/bindings/trivial-devices.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 27930708ccd5..e9a3a6f2c59e 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -287,8 +287,12 @@ properties:
> - mps,mp2857
> # Monolithic Power Systems Inc. multi-phase controller mp2888
> - mps,mp2888
> + # Monolithic Power Systems Inc. multi-phase controller mp2869a
> + - mps,mp2869a
69 < 88
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-06-24 7:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 7:41 [PATCH 1/2] hwmon: (pmbus) Add support for MPS multi-phase mp2869a/mp29612a controllers tzuhao.wtmh
2025-06-24 7:41 ` [PATCH 2/2] dt-bindings: trivial-devices: Add mp2869a/mp29612a device entry tzuhao.wtmh
2025-06-24 7:44 ` Krzysztof Kozlowski [this message]
2025-06-24 7:48 ` [PATCH 1/2] hwmon: (pmbus) Add support for MPS multi-phase mp2869a/mp29612a controllers Krzysztof Kozlowski
2025-06-25 6:31 ` 吳梓豪
2025-06-25 8:08 ` Krzysztof Kozlowski
2025-06-25 13:11 ` Guenter Roeck
2025-06-24 20:10 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4f45fbd-2929-491c-8f5e-413b9c481259@kernel.org \
--to=krzk@kernel.org \
--cc=Henry_Wu@quantatw.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Mariel.Tinaco@analog.com \
--cc=cedricjustine.encarnacion@analog.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=grantpeltier93@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=jdelvare@suse.com \
--cc=johnerasmusmari.geronimo@analog.com \
--cc=kimseer.paller@analog.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=leo.yang.sy0@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linux@weissschuh.net \
--cc=michal.simek@amd.com \
--cc=naresh.solanki@9elements.com \
--cc=ninad@linux.ibm.com \
--cc=noahwang.wang@outlook.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=rodrigo.gobbi.7@gmail.com \
--cc=tzuhao.wtmh@gmail.com \
--cc=xzeol@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).