From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10767C433FE for ; Tue, 18 Oct 2022 05:33:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229822AbiJRFdY (ORCPT ); Tue, 18 Oct 2022 01:33:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229731AbiJRFdX (ORCPT ); Tue, 18 Oct 2022 01:33:23 -0400 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B4FD9AF90; Mon, 17 Oct 2022 22:33:00 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=xianting.tian@linux.alibaba.com;NM=1;PH=DS;RN=23;SR=0;TI=SMTPD_---0VSTEQpA_1666071173; Received: from 30.221.96.155(mailfrom:xianting.tian@linux.alibaba.com fp:SMTPD_---0VSTEQpA_1666071173) by smtp.aliyun-inc.com; Tue, 18 Oct 2022 13:32:55 +0800 Message-ID: Date: Tue, 18 Oct 2022 13:32:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH V2 2/2] Documentation: kdump: describe VMCOREINFO export for RISCV64 To: Bagas Sanjaya Cc: paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, anup@brainfault.org, heiko@sntech.de, guoren@kernel.org, mick@ics.forth.gr, alexandre.ghiti@canonical.com, bhe@redhat.com, vgoyal@redhat.com, dyoung@redhat.com, corbet@lwn.net, Conor.Dooley@microchip.com, kexec@lists.infradead.org, linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, crash-utility@redhat.com, heinrich.schuchardt@canonical.com, k-hagio-ab@nec.com, hschauhan@nulltrace.org, yixun.lan@gmail.com References: <20221014134139.5151-1-xianting.tian@linux.alibaba.com> <20221014134139.5151-3-xianting.tian@linux.alibaba.com> From: Xianting Tian In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org 在 2022/10/18 上午11:19, Bagas Sanjaya 写道: > On Fri, Oct 14, 2022 at 09:41:39PM +0800, Xianting Tian wrote: >> The following interrelated definitions and ranges are needed by the kdump >> crash tool, they are exported by "arch/riscv/kernel/crash_core.c": > Better say "..., which are exported by ..." will fix it in v3 thanks > >> diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst b/Documentation/admin-guide/kdump/vmcoreinfo.rst >> index 6726f439958c..8e2e164cf3db 100644 >> --- a/Documentation/admin-guide/kdump/vmcoreinfo.rst >> +++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst >> @@ -595,3 +595,33 @@ X2TLB >> ----- >> >> Indicates whether the crashed kernel enabled SH extended mode. >> + >> +RISCV64 >> +======= >> + >> +VA_BITS >> +------- >> + >> +The maximum number of bits for virtual addresses. Used to compute the >> +virtual memory ranges. >> + >> +PAGE_OFFSET >> +----------- >> + >> +Indicates the virtual kernel start address of direct-mapped RAM region. >> + >> +phys_ram_base >> +------------- >> + >> +Indicates the start physical RAM address. >> + >> +MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END|KASAN_SHADOW_START|KASAN_SHADOW_END|KERNEL_LINK_ADDR|ADDRESS_SPACE_END >> +---------------------------------------------------------------------------------------------------------------------------------------------------- >> + >> +Used to get the correct ranges: >> + >> + * MODULES_VADDR ~ MODULES_END : Kernel module space. >> + * VMALLOC_START ~ VMALLOC_END : vmalloc() / ioremap() space. >> + * VMEMMAP_START ~ VMEMMAP_END : vmemmap region, used for struct page array. >> + * KASAN_SHADOW_START ~ KASAN_SHADOW_END : kasan shadow space. >> + * KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END : Kernel link and BPF space. > The documentation LGTM, thanks. > > When the patch subject is fixed, > > Reviewed-by: Bagas Sanjaya >