From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBA172F4A0E for ; Thu, 6 Nov 2025 12:17:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762431465; cv=none; b=Iz/dD2X5X2jQj50NIDQ5umf/6oUJGNsqan3dm6+TWLqjDFhzJxGg1KJDin6mtlCpdHstzxi1qskftwl+3dTnUV5t0wVq0Z66Dv3of0iIRkfSFLahwIWIT2PMbDi1UrcU1Ny/RglFtcv4JsY3JN+6loPZMvYcudeurQ7PQFofOLo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762431465; c=relaxed/simple; bh=9LV353o44e7iaytKxoKO3m56wFwJYwJhc6jN9BswQpM=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=pwA4VdnCQU2Pk/YW7DEo/uX4x/Dl5+tT+/fRBffozUEArdqac+uwtg2v2Am50JAZdYk1CVhu32vMSJe3d4bedJDJM8i49E+bxtf0n2/CfLdV4z0kJJj08VKB2+HN6b616M5Ni/buDbnl1408imXK4H1qmvZLgv46hWDSI2h9xEw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Km1ICHqM; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=eNJfxlhp; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Km1ICHqM"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="eNJfxlhp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762431462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sJOFsQmt4z32StWI73+K+fCNACFUE/4kjllWzy5Yuds=; b=Km1ICHqMq3xin53ItIWtUFhJ57OHDV1zDdgZscF8NJY9yN40vZjMgJtaHbUuqGLepGAaKA lUY0Lk4Lr7fTA021zAX7F7eUiXatinyjkLbygAozs4e/sVbeuKiZip9Iu/rG5ijqTdFDc4 zGqJSQQLW4gYPM4cyDGYAu6fgkqjLMU= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-663-QCb4JQZQMPiZvUu0wUc3gA-1; Thu, 06 Nov 2025 07:17:41 -0500 X-MC-Unique: QCb4JQZQMPiZvUu0wUc3gA-1 X-Mimecast-MFC-AGG-ID: QCb4JQZQMPiZvUu0wUc3gA_1762431460 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4775e54a70aso8629865e9.0 for ; Thu, 06 Nov 2025 04:17:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1762431460; x=1763036260; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=sJOFsQmt4z32StWI73+K+fCNACFUE/4kjllWzy5Yuds=; b=eNJfxlhpb0EtmNe4zpHP4H+ssnYCTOxUxUbU26NKQVuag87NkWcpY94Docy9z1GEJ7 DDIbEuab3l+8e+EhFt4wwYjOBlTYobHeMtKPRRzrqSUnzjK9gbyAOVYq0IChSAiR2zHU tQ+V/8YpvXmhiGpbM7kruWmRFxBTIuKqnWZ19D8NWwVuSieLhA1BOLwZEG3HtLrXcVgm eFD3cDtTYHEXQVI4pFT/NZbjebs4hCfs3K31r3P/ZXufnDZhtZtiPbiJAzhpWJ2vRB1/ 2djJEqci5M3DGEJg6e+PVFlof00Pck2WSEIFVemog8DopKHFc/qxUKMEG/YLBq1fJAGu yLKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762431460; x=1763036260; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sJOFsQmt4z32StWI73+K+fCNACFUE/4kjllWzy5Yuds=; b=kk/2sIQl6D1Nul4sqNcPrnLuV4tSg5aY/H+ZZvB+rYmcPItpSOW1QC/Ll6LFyN0TQ/ k088vA13tW8wLjJdJ77UVfrsFqD6W1/uK0pu0GKAN/ZYLV9juSi2ZXRQBsckRdX8ynJa 0Bgd+gUwtikSMVIOwkxuYQDuz97a4ah9wuTbJwPAmIKli8uMNuIpwaCfZ/vToIjqcOo6 bcdID0BZPlFyqFXEDIbUfUXlc6j4YMWw3gtipqZTTc95EnlXUPos2LbgfBGtmW6LIos6 ITUcUFMBOxL9RNFTaq/BWG4gue4AaF2/YIKG44AeDBgvS7o5VubQC6Z2wdiF1yhV5Vs8 APFQ== X-Forwarded-Encrypted: i=1; AJvYcCV/4FsfxKLT4CBLCVDNRD4dANO0QfhcgwA/dzbEszFD2BlqS5BYmb+LcDBVr6MRkARv26ZX4bjNuGA=@vger.kernel.org X-Gm-Message-State: AOJu0YyHrBuk7CoWs8znEW/FoT2JXKMdkn3q1nwGqh8+Mjy1Ll5es8lW ZrjXb5LUiHe2EET1IK0reMsDYu0y4WFKaOjBJd84fbWMVrisynOOjDhjVjoYKBwpgUH/MyWOecE Vv/nXfI/ZTabIul1HaIMToz/WEjEHAgpsfxd8YavSKboT+fMv7XIOLeopXM0RUw== X-Gm-Gg: ASbGncvbMq9VX2ZEDfGhLTcvMKE83NrqyBzQAKTB/kOa5gE4XlpC2ZWYCNU48qFQYbD NMttoimiQHqWr7Wqhzy2/RWkbH6rHGZ9KlMH4pwKVEZIW7EKmAIuJv8kpLzOSydR2sHGfCQnrnU 9uuQUPgQR6XiZWh1to4e+UWc7H2fTvoX3ku1U1Md7Gg8Z7w/lPIarYT4MXChgRfg0eq9WZx8ys5 xY/5fr03HpCk4B/DBoJOpQo+QluMnKBF5mPt056WPjMI9MkTgRpYsfAna9UeEX6tl06j0p+XIBQ b1dRE/Bn5aKZuleP6fW3xeiNTWp41i7Ir8PG5PMPIJbuvZHJO/8B02O+W4bhpJrtuVGV7RVaEfl cHA== X-Received: by 2002:a05:600c:4ed4:b0:477:3012:d285 with SMTP id 5b1f17b1804b1-4775cdacf5amr60826935e9.3.1762431460433; Thu, 06 Nov 2025 04:17:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IFPlniGNFV9Ibj9f6xLOEXX+53/yBS8AakakQvea5myq2HDP+liFvl4AiG9oo5p7c3OOkui0Q== X-Received: by 2002:a05:600c:4ed4:b0:477:3012:d285 with SMTP id 5b1f17b1804b1-4775cdacf5amr60826455e9.3.1762431459953; Thu, 06 Nov 2025 04:17:39 -0800 (PST) Received: from [192.168.88.32] ([212.105.155.83]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477626eb4fdsm44212655e9.17.2025.11.06.04.17.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Nov 2025 04:17:39 -0800 (PST) Message-ID: Date: Thu, 6 Nov 2025 13:17:37 +0100 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 net-next 11/14] tcp: accecn: unset ECT if receive or send ACE=0 in AccECN negotiaion To: chia-yu.chang@nokia-bell-labs.com, edumazet@google.com, parav@nvidia.com, linux-doc@vger.kernel.org, corbet@lwn.net, horms@kernel.org, dsahern@kernel.org, kuniyu@google.com, bpf@vger.kernel.org, netdev@vger.kernel.org, dave.taht@gmail.com, jhs@mojatatu.com, kuba@kernel.org, stephen@networkplumber.org, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, andrew+netdev@lunn.ch, donald.hunter@gmail.com, ast@fiberby.net, liuhangbin@gmail.com, shuah@kernel.org, linux-kselftest@vger.kernel.org, ij@kernel.org, ncardwell@google.com, koen.de_schepper@nokia-bell-labs.com, g.white@cablelabs.com, ingemar.s.johansson@ericsson.com, mirja.kuehlewind@ericsson.com, cheshire@apple.com, rs.ietf@gmx.at, Jason_Livingood@comcast.com, vidhi_goel@apple.com References: <20251030143435.13003-1-chia-yu.chang@nokia-bell-labs.com> <20251030143435.13003-12-chia-yu.chang@nokia-bell-labs.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20251030143435.13003-12-chia-yu.chang@nokia-bell-labs.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/30/25 3:34 PM, chia-yu.chang@nokia-bell-labs.com wrote: > @@ -4006,7 +4008,7 @@ struct sk_buff *tcp_make_synack(const struct sock *sk, struct dst_entry *dst, > memset(th, 0, sizeof(struct tcphdr)); > th->syn = 1; > th->ack = 1; > - tcp_ecn_make_synack(req, th); > + tcp_ecn_make_synack((struct sock *)sk, req, th); > th->source = htons(ireq->ir_num); > th->dest = ireq->ir_rmt_port; > skb->mark = ireq->ir_mark; Whoops, I missed the const cast in the previous revisions. This could make the code generated by the compiler for the caller incorrect - assuming the changed field is actually constant. I don't have a good idea on how to address this. Changing the argument type for the whole call chain looks like a no go. /P