From: Randy Dunlap <rdunlap@infradead.org>
To: Bagas Sanjaya <bagasdotme@gmail.com>, linux-kernel@vger.kernel.org
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 03/35] Documentation: block: correct spelling
Date: Fri, 27 Jan 2023 14:58:12 -0800 [thread overview]
Message-ID: <f88f03c9-06c6-dbf2-d67e-111b875b3c58@infradead.org> (raw)
In-Reply-To: <Y9OL+iyaQtXLSCKc@debian.me>
On 1/27/23 00:31, Bagas Sanjaya wrote:
> On Thu, Jan 26, 2023 at 10:39:33PM -0800, Randy Dunlap wrote:
>> diff -- a/Documentation/block/data-integrity.rst b/Documentation/block/data-integrity.rst
>> --- a/Documentation/block/data-integrity.rst
>> +++ b/Documentation/block/data-integrity.rst
>> @@ -209,7 +209,7 @@ will require extra work due to the appli
>> sector must be set, and the bio should have all data pages
>> added. It is up to the caller to ensure that the bio does not
>> change while I/O is in progress.
>> - Complete bio with error if prepare failed for some reson.
>> + Complete bio with error if prepare failed for some reason.
>>
>
> So if prepare returns error, bio is completed not successfully but also
> errored?
I think that
>> + Complete bio with error if prepare failed for some reason.
says that the caller of bio_integrity_prep() should treat the bio as an
error condition. I don't see any guarantee that the bio is completed
as far as adding an integrity payload to it, any more than what the bio
was upon calling bio_integrity_prep().
But I could also be wrong. :)
--
~Randy
next prev parent reply other threads:[~2023-01-27 22:58 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 6:39 [PATCH 00/35] Documentation: correct lots of spelling errors (series 1) Randy Dunlap
2023-01-27 6:39 ` [PATCH 02/35] Documentation: arm: correct spelling Randy Dunlap
2023-01-27 6:55 ` Mukesh Ojha
2023-01-27 6:39 ` [PATCH 01/35] Documentation: arm64: " Randy Dunlap
2023-01-27 7:02 ` Mukesh Ojha
2023-01-27 6:39 ` [PATCH 03/35] Documentation: block: " Randy Dunlap
2023-01-27 8:31 ` Bagas Sanjaya
2023-01-27 22:58 ` Randy Dunlap [this message]
2023-01-27 8:36 ` Mukesh Ojha
2023-01-27 6:39 ` [PATCH 04/35] Documentation: bpf: " Randy Dunlap
2023-01-27 8:29 ` Bagas Sanjaya
2023-01-28 19:38 ` Alexei Starovoitov
2023-01-30 14:24 ` David Vernet
2023-01-30 14:26 ` David Vernet
2023-01-27 6:39 ` [PATCH 05/35] Documentation: core-api: " Randy Dunlap
2023-01-27 15:25 ` Mukesh Ojha
2023-01-27 6:39 ` [PATCH 06/35] Documentation: fault-injection: " Randy Dunlap
2023-01-27 6:39 ` [PATCH 07/35] Documentation: fb: " Randy Dunlap
2023-01-27 6:39 ` [PATCH 08/35] Documentation: features: " Randy Dunlap
2023-01-27 6:39 ` [PATCH 09/35] Documentation: firmware-guide/acpi: " Randy Dunlap
2023-01-30 15:52 ` Rafael J. Wysocki
2023-01-27 6:39 ` [PATCH 10/35] Documentation: hid: " Randy Dunlap
2023-01-27 16:20 ` srinivas pandruvada
2023-02-06 14:01 ` (subset) " Benjamin Tissoires
2023-01-27 6:39 ` [PATCH 11/35] Documentation: i2c: " Randy Dunlap
2023-01-27 7:14 ` Wolfram Sang
2023-01-27 8:26 ` Bagas Sanjaya
2023-01-27 22:34 ` Randy Dunlap
2023-01-27 6:39 ` [PATCH 12/35] Documentation: input: " Randy Dunlap
2023-01-27 6:39 ` [PATCH 13/35] Documentation: isdn: " Randy Dunlap
2023-01-28 6:06 ` Jakub Kicinski
2023-01-27 6:39 ` [PATCH 14/35] Documentation: leds: " Randy Dunlap
2023-01-27 9:30 ` Lee Jones
2023-01-27 6:39 ` [PATCH 15/35] Documentation: litmus-tests: " Randy Dunlap
2023-01-27 6:39 ` [PATCH 16/35] Documentation: livepatch: " Randy Dunlap
2023-01-27 10:52 ` Petr Mladek
2023-01-27 6:39 ` [PATCH 17/35] Documentation: locking: " Randy Dunlap
2023-01-27 6:39 ` [PATCH 18/35] Documentation: mm: " Randy Dunlap
2023-01-27 6:44 ` HORIGUCHI NAOYA(堀口 直也)
2023-01-27 8:27 ` Bagas Sanjaya
2023-01-30 10:07 ` Mike Rapoport
2023-01-27 6:39 ` [PATCH 19/35] Documentation: openrisc: " Randy Dunlap
2023-01-27 6:39 ` [PATCH 20/35] Documentation: PCI: " Randy Dunlap
2023-01-27 15:55 ` Bjorn Helgaas
2023-01-27 6:39 ` [PATCH 22/35] Documentation: power: " Randy Dunlap
2023-01-27 6:39 ` [PATCH 21/35] Documentation: powerpc: " Randy Dunlap
2023-01-27 6:39 ` [PATCH 23/35] Documentation: s390: " Randy Dunlap
2023-01-27 11:43 ` Heiko Carstens
2023-01-27 6:39 ` [PATCH 24/35] Documentation: scheduler: " Randy Dunlap
2023-01-27 15:33 ` Mukesh Ojha
2023-01-27 6:39 ` [PATCH 25/35] Documentation: security: " Randy Dunlap
2023-01-27 6:39 ` [PATCH 26/35] Documentation: sound: " Randy Dunlap
2023-01-29 8:24 ` Takashi Iwai
2023-01-27 6:39 ` [PATCH 27/35] Documentation: spi: " Randy Dunlap
2023-01-27 6:39 ` [PATCH 28/35] Documentation: target: " Randy Dunlap
2023-02-08 23:13 ` Martin K. Petersen
2023-01-27 6:39 ` [PATCH 29/35] Documentation: timers: " Randy Dunlap
2023-01-27 6:40 ` [PATCH 30/35] Documentation: tools/rtla: " Randy Dunlap
2023-01-27 8:52 ` Daniel Bristot de Oliveira
2023-01-27 19:53 ` Steven Rostedt
2023-01-27 6:40 ` [PATCH 31/35] Documentation: trace: " Randy Dunlap
2023-01-27 7:05 ` Mukesh Ojha
2023-01-27 8:54 ` Daniel Bristot de Oliveira
2023-01-27 23:01 ` Randy Dunlap
2023-01-27 19:54 ` Steven Rostedt
2023-01-31 18:20 ` Suzuki K Poulose
2023-01-27 6:40 ` [PATCH 32/35] Documentation: usb: " Randy Dunlap
2023-01-27 6:40 ` [PATCH 33/35] Documentation: w1: " Randy Dunlap
2023-01-27 6:40 ` [PATCH 34/35] Documentation: x86: " Randy Dunlap
2023-01-27 6:40 ` [PATCH 35/35] Documentation: xtensa: " Randy Dunlap
2023-01-27 17:45 ` Max Filippov
2023-01-27 6:59 ` [PATCH 15/35] Documentation: litmus-tests: " David Howells
2023-01-27 14:59 ` Paul E. McKenney
2023-01-27 6:59 ` [PATCH 25/35] Documentation: security: " David Howells
2023-01-28 10:48 ` (subset) [PATCH 00/35] Documentation: correct lots of spelling errors (series 1) Mark Brown
2023-01-28 20:30 ` patchwork-bot+netdevbpf
2023-01-31 16:28 ` (subset) " Catalin Marinas
2023-02-14 16:57 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f88f03c9-06c6-dbf2-d67e-111b875b3c58@infradead.org \
--to=rdunlap@infradead.org \
--cc=axboe@kernel.dk \
--cc=bagasdotme@gmail.com \
--cc=corbet@lwn.net \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).