From: Carlos Bilbao <carlos.bilbao@amd.com>
To: Jonathan Corbet <corbet@lwn.net>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: ojeda@kernel.org, akiyks@gmail.com, jani.nikula@linux.intel.com,
rdunlap@infradead.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, konstantin@linuxfoundation.org
Subject: Re: [PATCH v5 0/2] docs: Integrate rustdoc into Rust documentation
Date: Wed, 4 Jan 2023 13:54:58 -0600 [thread overview]
Message-ID: <f94a3126-41ba-2263-eac3-ac877042c9ea@amd.com> (raw)
In-Reply-To: <874jt6cpw0.fsf@meer.lwn.net>
On 1/4/23 08:53, Jonathan Corbet wrote:
> Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> writes:
>
>> I think I understand now what you meant by "fail more gracefully". I
>> thought you meant fail with a better/proper message given versioning
>> information or similar, but you primarily meant avoid breaking the
>> entire docs build if the Rust part fails, right?
> Both would be nice, but not breaking the docs build would be at the top
> of my list.
There's a bunch of simple workarounds we can use to keep going even if
rustdoc fails, if that is agreeable. I'd test but maybe something like:
ifeq ($(CONFIG_RUST),y)
$(Q)$(MAKE) rustdoc || true
endif
or:
ifeq ($(CONFIG_RUST),y)
$(Q)$(MAKE) -k rustdoc
endif
or:
ifeq ($(CONFIG_RUST),y)
-$(Q)$(MAKE) -k rustdoc
endif
> Thanks,
>
> jon
Thanks,
Carlos
prev parent reply other threads:[~2023-01-04 19:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 17:30 [PATCH v4 0/2] docs: Integrate rustdoc into Rust documentation Carlos Bilbao
2022-12-07 17:30 ` [PATCH v4 1/2] docs: Move rustdoc output, cross-reference it Carlos Bilbao
2022-12-07 20:46 ` Jani Nikula
2022-12-07 22:57 ` Akira Yokosawa
2022-12-28 17:43 ` Carlos Bilbao
2022-12-07 17:30 ` [PATCH v4 2/2] docs: Integrate rustdoc generation into htmldocs Carlos Bilbao
2022-12-28 17:46 ` [PATCH v5 0/2] docs: Integrate rustdoc into Rust documentation Carlos Bilbao
2022-12-28 17:46 ` [PATCH v5 1/2] docs: Move rustdoc output, cross-reference it Carlos Bilbao
2022-12-28 17:46 ` [PATCH v5 2/2] docs: Integrate rustdoc generation into htmldocs Carlos Bilbao
2023-01-02 23:53 ` [PATCH v5 0/2] docs: Integrate rustdoc into Rust documentation Jonathan Corbet
2023-01-03 14:06 ` Carlos Bilbao
2023-01-04 0:20 ` Jonathan Corbet
2023-01-03 14:19 ` Miguel Ojeda
2023-01-04 0:25 ` Jonathan Corbet
2023-01-04 1:55 ` Miguel Ojeda
2023-01-04 14:53 ` Jonathan Corbet
2023-01-04 19:54 ` Carlos Bilbao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f94a3126-41ba-2263-eac3-ac877042c9ea@amd.com \
--to=carlos.bilbao@amd.com \
--cc=akiyks@gmail.com \
--cc=corbet@lwn.net \
--cc=jani.nikula@linux.intel.com \
--cc=konstantin@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).