From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01319C54EAA for ; Sun, 22 Jan 2023 11:47:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229920AbjAVLrJ (ORCPT ); Sun, 22 Jan 2023 06:47:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229566AbjAVLrI (ORCPT ); Sun, 22 Jan 2023 06:47:08 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08A0810F8 for ; Sun, 22 Jan 2023 03:47:07 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id g10so7099224wmo.1 for ; Sun, 22 Jan 2023 03:47:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=M2dS08c5mDDQCSEte2hJr4AncAP49BS6JfkPW/bfJ8w=; b=x60lhg9Ma84/nhgHooGxFDRzaGCTbna6N3OaUhRahz7oFK/Ej2LoBvR8cIclfA+YEc 075GAFy/Z+6wvaDI7Vtr/jDBAOmZuEsq7tCWLkeLwtI7bPex58Pm6EjC3JMzpJ+57MIn 5T0guh+4iRpkxNWNtfXUGJ63DWXecs+xrEq2+1kGSbEQy5zzLYNSKRU3hy9nS/WC9k2z Gw7aqPry1lPoo9c8A0gEHtEbhMhcD45BAJ6wFHyQcSt+myMtZ/qlgR2AaS8964Zn2P4p UWrCS1Ld/U0RPkqYhhWftQwPG1iq5ZpzAjpwY1XCjBtkkZztPouO1E9exFAGh5clvnfx PSYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M2dS08c5mDDQCSEte2hJr4AncAP49BS6JfkPW/bfJ8w=; b=pxfflSC66JvtFR2XCAp7GRIJhmz7JR4X1ac3S3U5Jo1/w1+JQNsL7y/ttpx6vrzcKP ksQpkaCHlhy0br16mhDBMaRVFEX9m7jf+yL7+5qVI18echHp0vttulY5kAlaz8vnRPuj BGymruFTjHyZP3+8ncsoy91XD141cwwI/bOBeoIL1I5V9Vyuz4zKa1RSFgKkumMrWY9G 1HcTuGNRQm/ryYaijATZb+8GH2pwbSxXGMQOSrm9kwV2B2meGVz4/wVwGDuTo1Roqwtk Vp0oMZrhDN69c8rqe6tNONAKMJdIOFyTN6xGAvhJMjWwIwJfmSKK3b5ZlZeqcpVw50oD nKBg== X-Gm-Message-State: AFqh2kqBL7pJYbIH9JRmySgvh/CuoP4DGpO1jjDyfeELP6T3eeUDQjWR m+C1xE8ygds0rI3xNudbh/JihA== X-Google-Smtp-Source: AMrXdXvv5SOq8oLh4MHQyQrfcxkhDTk8DLHjQASO2lJraohGjZ9veTwuZ0pwUHGY71DEX8EYBAct8g== X-Received: by 2002:a05:600c:4f82:b0:3db:25a0:ca5b with SMTP id n2-20020a05600c4f8200b003db25a0ca5bmr11762781wmq.37.1674388025485; Sun, 22 Jan 2023 03:47:05 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id h15-20020a05600c350f00b003db0b0cc2afsm8452351wmq.30.2023.01.22.03.47.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Jan 2023 03:47:04 -0800 (PST) Message-ID: Date: Sun, 22 Jan 2023 12:47:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [RFC PATCH v2 03/31] Documentation: Add binding for kalray,kv3-1-apic-gic Content-Language: en-US To: Yann Sionneau , Arnd Bergmann , Jonathan Corbet , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Will Deacon , Peter Zijlstra , Boqun Feng , Mark Rutland , Eric Biederman , Kees Cook , Oleg Nesterov , Ingo Molnar , Waiman Long , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Paul Moore , Eric Paris , Christian Brauner , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jules Maselbas , Guillaume Thouvenin , Clement Leger , Vincent Chardon , =?UTF-8?Q?Marc_Poulhi=c3=a8s?= , Julian Vetter , Samuel Jones , Ashley Lesdalons , Thomas Costis , Marius Gligor , Jonathan Borne , Julien Villette , Luc Michel , Louis Morhet , Julien Hascoet , Jean-Christophe Pince , Guillaume Missonnier , Alex Michon , Huacai Chen , WANG Xuerui , Shaokun Zhang , John Garry , Guangbin Huang , Bharat Bhushan , Bibo Mao , Atish Patra , "Jason A. Donenfeld" , Qi Liu , Jiaxun Yang , Catalin Marinas , Mark Brown , Janosch Frank , Alexey Dobriyan Cc: Benjamin Mugnier , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-audit@redhat.com, linux-riscv@lists.infradead.org, bpf@vger.kernel.org References: <20230120141002.2442-1-ysionneau@kalray.eu> <20230120141002.2442-4-ysionneau@kalray.eu> From: Krzysztof Kozlowski In-Reply-To: <20230120141002.2442-4-ysionneau@kalray.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 20/01/2023 15:09, Yann Sionneau wrote: > From: Jules Maselbas > > Add documentation for `kalray,kv3-1-apic-gic` binding. > > Co-developed-by: Jules Maselbas > Signed-off-by: Jules Maselbas > Signed-off-by: Yann Sionneau > --- All the comments apply here and to all your other patches - wrong subject, missing blank lines, missing additionalProperties, missing tests (patches were for sure not tested as you can see from bot's answers) etc. Really, please start from scratch on example-schema. > > Notes: > V1 -> V2: new patch > > .../kalray,kv3-1-apic-gic.yaml | 66 +++++++++++++++++++ > 1 file changed, 66 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-apic-gic.yaml > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-apic-gic.yaml b/Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-apic-gic.yaml > new file mode 100644 > index 000000000000..7a37f19db2fb > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-apic-gic.yaml > @@ -0,0 +1,66 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/interrupt-controller/kalray,kv3-1-apic-gic# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Kalray kv3-1 APIC-GIC > + > +description: | > + Each cluster in the Coolidge SoC includes an Advanced Programmable Interrupt > + Controller (APIC) which is split in two part: > + - a Generic Interrupt Controller (referred as APIC-GIC) > + - a Mailbox Controller (referred as APIC-Mailbox) > + The APIC-GIC acts as an intermediary interrupt controller, muxing/routing > + incoming interrupts to output interrupts connected to kvx cores interrupts lines. > + The 139 possible input interrupt lines are organized as follow: > + - 128 from the mailbox controller (one it per mailboxes) > + - 1 from the NoC router > + - 5 from IOMMUs > + - 1 from L2 cache DMA job FIFO > + - 1 from cluster watchdog > + - 2 for SECC, DECC > + - 1 from Data NoC > + The 72 possible output interrupt lines: > + - 68 : 4 interrupts per cores (17 cores) > + - 1 for L2 cache controller > + - 3 extra that are for padding > + > +allOf: > + - $ref: /schemas/interrupt-controller.yaml# > + > +properties: > + compatible: > + const: kalray,kv3-1-apic-gic Missing reg > + "#interrupt-cells": > + const: 1 > + description: > + The IRQ number. > + interrupt-controller: true > + interrupt-parent: true Drop, should not be needed. > + interrupts: > + maxItems: 4 > + description: | > + Specifies the interrupt line(s) in the interrupt-parent controller node; > + valid values depend on the type of parent interrupt controller > + > +required: > + - compatible > + - reg > + - "#interrupt-cells" > + - interrupt-controller > + - interrupt-parent > + - interrupts > + > +examples: > + - | > + apic_gic: interrupt-controller@a20000 { > + compatible = "kalray,kv3-1-apic-gic"; > + reg = <0 0xa20000 0 0x12000>; > + #interrupt-cells = <1>; > + interrupt-controller; > + interrupt-parent = <&intc>; > + interrups = <4 5 6 7>; > + }; > + > +... Best regards, Krzysztof