From: Mario Limonciello <mario.limonciello@amd.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Cc: Andreas Noever <andreas.noever@gmail.com>,
Mika Westerberg <westeri@kernel.org>,
Yehezkel Bernat <YehezkelShB@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-usb@vger.kernel.org, linux-doc@vger.kernel.org,
Sanath S <Sanath.S@amd.com>
Subject: Re: [PATCH 2/3] thunderbolt: Reset the host interface before reusing a DMA HopID
Date: Mon, 5 Oct 2026 10:12:41 -0500 [thread overview]
Message-ID: <fb5486b1-1a93-4fbb-8e6e-e4145665714e@amd.com> (raw)
In-Reply-To: <20261005143535.GM176164@black.igk.intel.com>
On 10/5/26 09:35, Mika Westerberg wrote:
> Hi,
>
> On Mon, Oct 05, 2026 at 07:13:40PM +0530, Basavaraj Natikar wrote:
>> +++ b/drivers/thunderbolt/nhi.c
>> @@ -17,6 +17,7 @@
>> #include <linux/iommu.h>
>> #include <linux/lockdep.h>
>> #include <linux/module.h>
>> +#include <linux/pci.h>
>
> I haven't looked at the code at all yet but this one is no-go. We are
> trying to make the NHI code generic that can work with any interconnect,
> like the controllers on ARM based SoCs (aka platform bus) and that's why we
> have pci.c for the PCIe based NHIs.
To add to that - what tree did you base on? I tried on thunderbolt/next
(a93a8e3200002f0c345fec4c340390e9a60aabc7) and it doesn't apply.
╰─❯ b4 shazam
https://lore.kernel.org/linux-usb/cover.1790854235.git.Basavaraj.Natikar@amd.com/T/#m2e70efa2f627df231d9f975424096587b819a354
Looking up
https://lore.kernel.org/all/cover.1790854235.git.Basavaraj.Natikar@amd.com/
Grabbing thread from
lore.kernel.org/all/cover.1790854235.git.Basavaraj.Natikar@amd.com/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 5 messages in the thread
Analyzing 0 code-review messages
Checking attestation on all messages, may take a moment...
---
✓ [PATCH 1/3] thunderbolt: Allow tb_ring_start() to fail
✓ [PATCH 2/3] thunderbolt: Reset the host interface before reusing a
DMA HopID
✓ [PATCH 3/3] thunderbolt: Add quirk to reset host interface for AMD
USB4 routers
---
✓ Signed: DKIM/amd.com
---
Total patches: 3
---
Applying: thunderbolt: Allow tb_ring_start() to fail
Applying: thunderbolt: Reset the host interface before reusing a DMA HopID
Patch failed at 0002 thunderbolt: Reset the host interface before
reusing a DMA HopID
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
error: patch failed: drivers/thunderbolt/nhi.c:17
error: drivers/thunderbolt/nhi.c: patch does not apply
error: patch failed: drivers/thunderbolt/nhi.h:123
error: drivers/thunderbolt/nhi.h: patch does not apply
error: patch failed: drivers/thunderbolt/nhi_regs.h:115
error: drivers/thunderbolt/nhi_regs.h: patch does not apply
hint: Use 'git am --show-current-patch=diff' to see the failed patch
next prev parent reply other threads:[~2026-10-05 15:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 13:43 [PATCH 0/3] thunderbolt: Reset affected AMD host interfaces before DMA HopID reuse Basavaraj Natikar
2026-10-05 13:43 ` [PATCH 1/3] thunderbolt: Allow tb_ring_start() to fail Basavaraj Natikar
2026-10-06 4:27 ` Mika Westerberg
2026-10-05 13:43 ` [PATCH 2/3] thunderbolt: Reset the host interface before reusing a DMA HopID Basavaraj Natikar
2026-10-05 14:35 ` Mika Westerberg
2026-10-05 15:12 ` Mario Limonciello [this message]
2026-10-05 16:50 ` Basavaraj Natikar
2026-10-06 4:33 ` Mika Westerberg
2026-10-06 14:47 ` Basavaraj Natikar
2026-10-05 13:43 ` [PATCH 3/3] thunderbolt: Add quirk to reset host interface for AMD USB4 routers Basavaraj Natikar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb5486b1-1a93-4fbb-8e6e-e4145665714e@amd.com \
--to=mario.limonciello@amd.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=Sanath.S@amd.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=pabeni@redhat.com \
--cc=westeri@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).