From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65A36277029; Mon, 16 Mar 2026 14:31:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773671488; cv=none; b=EFprvwqJfNh7sFhYJ0Jeoul5NVzImWOeYtT5nXY1eY1dADaFMBNXloVqY55l+C/B0266AmFHTPJHcV8lbBDmER77ZmJzWxdokko2kHWP2H9zyH6hpkSmOCXW6JCaFOaQ+p5LiHkbLGBLefPLYc/WIXISmEB14poWL5XhsnL3g8U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773671488; c=relaxed/simple; bh=wmwRlESgrnvepPbb1PirkwNJB9yCJFViHuseAPzZgTU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=S8lvj6JZSYNsQRHR8W8Sc6LBAyls3N54lM/mJS3zaN3RkBKOAmprstpl4Elcuc+gRuZc8SPPqa2dHgeNtOtNa+DlpjRRmDTrpro+KzoC+RBELreYKxzbbdCczSfM6IkulaqYnok9KFlYJ5E7+DDxQwAOMGx9Sg5xcB+PZ34Dgpc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=X1MvHmFe; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="X1MvHmFe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC85CC19421; Mon, 16 Mar 2026 14:31:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773671488; bh=wmwRlESgrnvepPbb1PirkwNJB9yCJFViHuseAPzZgTU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X1MvHmFeTMXLS17UDbf4qKWdxfdfl1nIIM1Znjt/hB9Jrz7XpIjRGeKs/GgD5HbmT GJnoLBvTQBD3mLyiQNYu/uMaiNpDmAFyJZxaGwL4kth9NMa+7N8pWmipLI9MOUnNIm XZuQWf4hbnuJkGt5El0XdUQ+XGEEEj/ffydaRt0U7/71pqXpi7xrliHkFxDB3ruYpx nd8CvutsY0NcvbrtfRvTcx8uB1G0uZ0HoUdnCcCHmTSa8GQRX3yC4bOT9X7R/YGAmG CL3fSgSn9uu67vMXPRuf0GENu4YKm6u93U51R6SiQiRnK+y3zr8woWQTM2An6cXIJn BxJKdQaXB4REg== Date: Mon, 16 Mar 2026 14:31:17 +0000 From: "Lorenzo Stoakes (Oracle)" To: Suren Baghdasaryan Cc: Andrew Morton , Jonathan Corbet , Clemens Ladisch , Arnd Bergmann , Greg Kroah-Hartman , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Alexander Shishkin , Maxime Coquelin , Alexandre Torgue , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Bodo Stroesser , "Martin K . Petersen" , David Howells , Marc Dionne , Alexander Viro , Christian Brauner , Jan Kara , David Hildenbrand , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Michal Hocko , Jann Horn , Pedro Falcato , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org, linux-staging@lists.linux.dev, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Ryan Roberts Subject: Re: [PATCH 03/15] mm: document vm_operations_struct->open the same as close() Message-ID: References: <52a7b9a003ea51521ab3c0baf30337a7800a3af7.1773346620.git.ljs@kernel.org> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sun, Mar 15, 2026 at 05:43:41PM -0700, Suren Baghdasaryan wrote: > On Thu, Mar 12, 2026 at 1:27 PM Lorenzo Stoakes (Oracle) wrote: > > > > Describe when the operation is invoked and the context in which it is > > invoked, matching the description already added for vm_op->close(). > > > > While we're here, update all outdated references to an 'area' field for > > VMAs to the more consistent 'vma'. > > > > Signed-off-by: Lorenzo Stoakes (Oracle) > > --- > > include/linux/mm.h | 15 ++++++++++----- > > 1 file changed, 10 insertions(+), 5 deletions(-) > > > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > index cc5960a84382..12a0b4c63736 100644 > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -748,15 +748,20 @@ struct vm_uffd_ops; > > * to the functions called when a no-page or a wp-page exception occurs. > > */ > > struct vm_operations_struct { > > - void (*open)(struct vm_area_struct * area); > > + /** > > + * @open: Called when a VMA is remapped or split. Not called upon first > > + * mapping a VMA. > > It's also called from dup_mmap() which is part of forking. Ah yup :) will update thanks! > > > + * Context: User context. May sleep. Caller holds mmap_lock. > > + */ > > + void (*open)(struct vm_area_struct *vma); > > /** > > * @close: Called when the VMA is being removed from the MM. > > * Context: User context. May sleep. Caller holds mmap_lock. > > */ > > - void (*close)(struct vm_area_struct * area); > > + void (*close)(struct vm_area_struct *vma); > > /* Called any time before splitting to check if it's allowed */ > > - int (*may_split)(struct vm_area_struct *area, unsigned long addr); > > - int (*mremap)(struct vm_area_struct *area); > > + int (*may_split)(struct vm_area_struct *vma, unsigned long addr); > > + int (*mremap)(struct vm_area_struct *vma); > > /* > > * Called by mprotect() to make driver-specific permission > > * checks before mprotect() is finalised. The VMA must not > > @@ -768,7 +773,7 @@ struct vm_operations_struct { > > vm_fault_t (*huge_fault)(struct vm_fault *vmf, unsigned int order); > > vm_fault_t (*map_pages)(struct vm_fault *vmf, > > pgoff_t start_pgoff, pgoff_t end_pgoff); > > - unsigned long (*pagesize)(struct vm_area_struct * area); > > + unsigned long (*pagesize)(struct vm_area_struct *vma); > > > > /* notification that a previously read-only page is about to become > > * writable, if an error is returned it will cause a SIGBUS */ > > -- > > 2.53.0 > > Cheers, Lorenzo