From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-6.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 98E057D8A8 for ; Mon, 26 Nov 2018 22:16:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727245AbeK0JMB (ORCPT ); Tue, 27 Nov 2018 04:12:01 -0500 Received: from mga01.intel.com ([192.55.52.88]:37928 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726634AbeK0JMB (ORCPT ); Tue, 27 Nov 2018 04:12:01 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Nov 2018 14:16:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,284,1539673200"; d="scan'208";a="284119183" Received: from rchatre-mobl.amr.corp.intel.com (HELO [10.24.14.87]) ([10.24.14.87]) by fmsmga005.fm.intel.com with ESMTP; 26 Nov 2018 14:16:25 -0800 Subject: Re: [PATCH v9 10/13] x86/resctrl: Fix the messages in rdt_last_cmd_printf and rdt_last_cmd_puts To: "Moger, Babu" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "corbet@lwn.net" , "fenghua.yu@intel.com" , "peterz@infradead.org" , "gregkh@linuxfoundation.org" , "davem@davemloft.net" , "akpm@linux-foundation.org" Cc: "hpa@zytor.com" , "x86@kernel.org" , "mchehab+samsung@kernel.org" , "arnd@arndb.de" , "kstewart@linuxfoundation.org" , "pombredanne@nexb.com" , "rafael@kernel.org" , "kirill.shutemov@linux.intel.com" , "tony.luck@intel.com" , "qianyue.zj@alibaba-inc.com" , "xiaochen.shen@intel.com" , "pbonzini@redhat.com" , "Singh, Brijesh" , "Hurwitz, Sherry" , "dwmw2@infradead.org" , "Lendacky, Thomas" , "luto@kernel.org" , "joro@8bytes.org" , "jannh@google.com" , "vkuznets@redhat.com" , "rian@alum.mit.edu" , "jpoimboe@redhat.com" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" References: <20181121202811.4492-1-babu.moger@amd.com> <20181121202811.4492-11-babu.moger@amd.com> From: Reinette Chatre Message-ID: Date: Mon, 26 Nov 2018 14:16:24 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181121202811.4492-11-babu.moger@amd.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Hi Babu and Borislav, Two typos seemed to have slipped through into the merged commit ... On 11/21/2018 12:28 PM, Moger, Babu wrote: > @@ -163,14 +163,14 @@ int parse_cbm(struct rdt_parse_data *data, struct rdt_resource *r, > * either is exclusive. > */ > if (rdtgroup_cbm_overlaps(r, d, cbm_val, rdtgrp->closid, true)) { > - rdt_last_cmd_printf("overlaps with exclusive group\n"); > + rdt_last_cmd_printf("Overlaps with exclusive group\n"); > return -EINVAL; > } > > if (rdtgroup_cbm_overlaps(r, d, cbm_val, rdtgrp->closid, false)) { > if (rdtgrp->mode == RDT_MODE_EXCLUSIVE || > rdtgrp->mode == RDT_MODE_PSEUDO_LOCKSETUP) { > - rdt_last_cmd_printf("overlaps with other group\n"); > + rdt_last_cmd_printf("0verlaps with other group\n"); > return -EINVAL; > } > } There is a zero instead of O used in second "Overlaps". > @@ -1235,7 +1235,7 @@ static ssize_t rdtgroup_mode_write(struct kernfs_open_file *of, > goto out; > rdtgrp->mode = RDT_MODE_PSEUDO_LOCKSETUP; > } else { > - rdt_last_cmd_printf("unknown/unsupported mode\n"); > + rdt_last_cmd_printf("Unknown orunsupported mode\n"); > ret = -EINVAL; > } Missing a space. Reinette