From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-6.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 084A27D2F0 for ; Fri, 2 Aug 2019 14:24:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390684AbfHBOYE (ORCPT ); Fri, 2 Aug 2019 10:24:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:37488 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731067AbfHBOYE (ORCPT ); Fri, 2 Aug 2019 10:24:04 -0400 Received: from [192.168.0.101] (unknown [180.111.32.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DA07F20679; Fri, 2 Aug 2019 14:24:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564755843; bh=TgNcbo6TXcLbjq5+6OYqRgo/Qoe3xOKUkbU920IR4iE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=QdJbHI4QqAf5coM6w57j/GQ9wNbAmk57r70Ay5RmCr8gUGhWlTy5PBEM5C4Q9zS5b BYxLuLKi1vFk7ymoVG9ICyvdZuUyI3H3IT5y+uj/bvDjvExZo9yOtoEANv0ymSdKIS 3Ev9S/1AokA1xrp+CoDJCxpYvVX/4paPncNoZs1k= Subject: Re: [PATCH] mailmap: add entry for Jaegeuk Kim To: Jonathan Corbet , Chao Yu Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, jaegeuk@kernel.org References: <20190802012135.31419-1-yuchao0@huawei.com> <20190802072626.405246e3@lwn.net> From: Chao Yu Message-ID: Date: Fri, 2 Aug 2019 22:23:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190802072626.405246e3@lwn.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 2019-8-2 21:26, Jonathan Corbet wrote: > On Fri, 2 Aug 2019 09:21:35 +0800 > Chao Yu wrote: > >> Add entry to connect all Jaegeuk's email addresses. >> >> Acked-by: Jaegeuk Kim >> Signed-off-by: Chao Yu >> --- >> .mailmap | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/.mailmap b/.mailmap >> index 477debe3d960..70d41c86e644 100644 >> --- a/.mailmap >> +++ b/.mailmap >> @@ -89,6 +89,9 @@ Henrik Kretzschmar >> Henrik Rydberg >> Herbert Xu >> Jacob Shin >> +Jaegeuk Kim >> +Jaegeuk Kim >> +Jaegeuk Kim > > So as I understand it, the mailmap file is there mostly to ensure that a > person's changesets are properly collected in 'git shortlog' and such. As > documented on the man page, it is used when a person's name is spelled > differently at different times. > > That doesn't appear to be the case here, and shortlog output is correct > already. Given that, do we *really* need to maintain a collection of old > email addresses in the mailmap file? What is the benefit of that? IMO, when we use git-blame to find out who is response for specified code, w/o mailmap we may just found old obsolete email address in the related commit; even we can search full name for his/her new email address, how can we make sure they are the same person... so anyway, it can help to find last valid/canonical email address of someone. Thanks, > > Thanks, > > jon >