Re: [PATCH v4] PCI: endpoint: pci-epf-test: Allow overriding default BAR sizes

[Damien Le Moal <dlemoal@kernel.org>]

On 1/29/26 22:23, Niklas Cassel wrote:
> Add bar{0,1,2,3,4,5}_size attributes in configfs, so that the user is not
> restricted to run pci-epf-test with the hardcoded BAR size values defined
> in pci-epf-test.c.
> 
> This code is shamelessly more or less copy pasted from pci-epf-vntb.c
> 
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Tested-by: Koichiro Den <den@valinux.co.jp>
> Signed-off-by: Niklas Cassel <cassel@kernel.org>

Looks OK to me.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

One nit below.


> +#define PCI_EPF_TEST_BAR_SIZE_W(_name, _id)				\
> +static ssize_t pci_epf_test_##_name##_store(struct config_item *item,	\
> +					    const char *page,		\
> +					    size_t len)			\
> +{									\
> +	struct config_group *group = to_config_group(item);		\
> +	struct pci_epf_test *epf_test =					\
> +		container_of(group, struct pci_epf_test, group);	\
> +	int val;							\
> +	int ret;							\

You can use one line to declare both variables.

> +									\
> +	/*								\
> +	 * BAR sizes can only be modified before binding to an EPC,	\
> +	 * pci_epf_test_alloc_space() is called in .bind().		\
> +	 */								\
> +	if (epf_test->epf->epc)						\
> +		return -EINVAL;						\
> +									\
> +	ret = kstrtouint(page, 0, &val);				\
> +	if (ret)							\
> +		return ret;						\
> +									\
> +	if (!is_power_of_2(val))					\
> +		return -EINVAL;						\
> +									\
> +	epf_test->bar_size[_id] = val;					\
> +									\
> +	return len;							\
> +}


-- 
Damien Le Moal
Western Digital Research