From: Randy Dunlap <rdunlap@infradead.org>
To: Alok Tiwari <alok.a.tiwari@oracle.com>,
linux-nvme@lists.infradead.org, kbusch@kernel.org,
axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, kch@nvidia.com,
nilay@linux.ibm.com, corbet@lwn.net
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] nvme: Fix typo in status code constant for self-test in progress
Date: Mon, 23 Jun 2025 13:46:17 -0700 [thread overview]
Message-ID: <ff61ff8e-d20c-444e-988f-6d97a197e070@infradead.org> (raw)
In-Reply-To: <20250623064036.4187788-5-alok.a.tiwari@oracle.com>
On 6/22/25 11:40 PM, Alok Tiwari wrote:
> Corrected a typo error in the NVMe status code constant from
> NVME_SC_SELT_TEST_IN_PROGRESS to NVME_SC_SELF_TEST_IN_PROGRESS to
> accurately reflect its meaning.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/nvme/host/constants.c | 4 ++--
> include/linux/nvme.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/nvme/host/constants.c b/drivers/nvme/host/constants.c
> index 1a0058be58210..dc90df9e13a21 100644
> --- a/drivers/nvme/host/constants.c
> +++ b/drivers/nvme/host/constants.c
> @@ -133,7 +133,7 @@ static const char * const nvme_statuses[] = {
> [NVME_SC_NS_NOT_ATTACHED] = "Namespace Not Attached",
> [NVME_SC_THIN_PROV_NOT_SUPP] = "Thin Provisioning Not Supported",
> [NVME_SC_CTRL_LIST_INVALID] = "Controller List Invalid",
> - [NVME_SC_SELT_TEST_IN_PROGRESS] = "Device Self-test In Progress",
> + [NVME_SC_SELF_TEST_IN_PROGRESS] = "Device Self-test In Progress",
> [NVME_SC_BP_WRITE_PROHIBITED] = "Boot Partition Write Prohibited",
> [NVME_SC_CTRL_ID_INVALID] = "Invalid Controller Identifier",
> [NVME_SC_SEC_CTRL_STATE_INVALID] = "Invalid Secondary Controller State",
> @@ -145,7 +145,7 @@ static const char * const nvme_statuses[] = {
> [NVME_SC_BAD_ATTRIBUTES] = "Conflicting Attributes",
> [NVME_SC_INVALID_PI] = "Invalid Protection Information",
> [NVME_SC_READ_ONLY] = "Attempted Write to Read Only Range",
> - [NVME_SC_CMD_SIZE_LIM_EXCEEDED ] = "Command Size Limits Exceeded",
> + [NVME_SC_CMD_SIZE_LIM_EXCEEDED] = "Command Size Limits Exceeded",
> [NVME_SC_ZONE_BOUNDARY_ERROR] = "Zoned Boundary Error",
> [NVME_SC_ZONE_FULL] = "Zone Is Full",
> [NVME_SC_ZONE_READ_ONLY] = "Zone Is Read Only",
> diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> index b65a1b9f2116c..655d194f8e722 100644
> --- a/include/linux/nvme.h
> +++ b/include/linux/nvme.h
> @@ -2155,7 +2155,7 @@ enum {
> NVME_SC_NS_NOT_ATTACHED = 0x11a,
> NVME_SC_THIN_PROV_NOT_SUPP = 0x11b,
> NVME_SC_CTRL_LIST_INVALID = 0x11c,
> - NVME_SC_SELT_TEST_IN_PROGRESS = 0x11d,
> + NVME_SC_SELF_TEST_IN_PROGRESS = 0x11d,
> NVME_SC_BP_WRITE_PROHIBITED = 0x11e,
> NVME_SC_CTRL_ID_INVALID = 0x11f,
> NVME_SC_SEC_CTRL_STATE_INVALID = 0x120,
--
~Randy
next prev parent reply other threads:[~2025-06-23 20:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 6:40 [PATCH 1/5] nvme: Fix multiple spelling and grammar issues in host drivers Alok Tiwari
2025-06-23 6:40 ` [PATCH 2/5] nvme: Fix incorrect variable in io cqes error message Alok Tiwari
2025-06-23 20:44 ` Randy Dunlap
2025-06-23 6:40 ` [PATCH 3/5] nvmet: Remove redundant assignment of error code in nvmet_ns_enable() Alok Tiwari
2025-06-23 20:45 ` Randy Dunlap
2025-06-23 6:40 ` [PATCH 4/5] nvme: Fix typo in status code constant for self-test in progress Alok Tiwari
2025-06-23 20:46 ` Randy Dunlap [this message]
2025-06-23 6:40 ` [PATCH 5/5] docs: nvme: fix grammar in nvme-pci-endpoint-target.rst Alok Tiwari
2025-06-23 20:39 ` Randy Dunlap
2025-06-23 20:44 ` [PATCH 1/5] nvme: Fix multiple spelling and grammar issues in host drivers Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff61ff8e-d20c-444e-988f-6d97a197e070@infradead.org \
--to=rdunlap@infradead.org \
--cc=alok.a.tiwari@oracle.com \
--cc=axboe@kernel.dk \
--cc=corbet@lwn.net \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).