[PATCH v2 1/2] docs: dt: fix documented Primecell compatible string

[PATCH v2 1/2] docs: dt: fix documented Primecell compatible string

[Baruch Siach]

Only arm,primecell is documented as compatible string for Primecell
peripherals. Current code agrees with that.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
v2:

  Split the translation update to a separate patch
---
 Documentation/devicetree/usage-model.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/usage-model.rst b/Documentation/devicetree/usage-model.rst
index b6a287955ee5..0717426856b2 100644
--- a/Documentation/devicetree/usage-model.rst
+++ b/Documentation/devicetree/usage-model.rst
@@ -415,6 +415,6 @@ When using the DT, this creates problems for of_platform_populate()
 because it must decide whether to register each node as either a
 platform_device or an amba_device.  This unfortunately complicates the
 device creation model a little bit, but the solution turns out not to
-be too invasive.  If a node is compatible with "arm,amba-primecell", then
+be too invasive.  If a node is compatible with "arm,primecell", then
 of_platform_populate() will register it as an amba_device instead of a
 platform_device.
-- 
2.39.2

[PATCH v2 2/2] docs: zh_CN/devicetree: sync usage-model fix

[Baruch Siach]

Sync compatibly string fix from the English document.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
v2:

  New separate patch for translation
---
 Documentation/translations/zh_CN/devicetree/usage-model.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/translations/zh_CN/devicetree/usage-model.rst b/Documentation/translations/zh_CN/devicetree/usage-model.rst
index c6aee82c7e6e..19ba4ae0cd81 100644
--- a/Documentation/translations/zh_CN/devicetree/usage-model.rst
+++ b/Documentation/translations/zh_CN/devicetree/usage-model.rst
@@ -325,6 +325,6 @@ Primecell设备。然而，棘手的一点是，AMBA总线上的所有设备并
 
 当使用DT时，这给of_platform_populate()带来了问题，因为它必须决定是否将
 每个节点注册为platform_device或amba_device。不幸的是，这使设备创建模型
-变得有点复杂，但解决方案原来并不是太具有侵略性。如果一个节点与“arm,amba-primecell”
+变得有点复杂，但解决方案原来并不是太具有侵略性。如果一个节点与“arm,primecell”
 兼容，那么of_platform_populate()将把它注册为amba_device而不是
 platform_device。
-- 
2.39.2

Re: [PATCH v2 1/2] docs: dt: fix documented Primecell compatible string

[Baruch Siach]

Hi Rob, Krzysztof,

On Mon, Apr 24 2023, Baruch Siach wrote:
> Only arm,primecell is documented as compatible string for Primecell
> peripherals. Current code agrees with that.

Once again my patches do not show up in patchwork. But they do show in
lore:

  https://lore.kernel.org/linux-devicetree/9e137548c4e76e0d8deef6d49460cb37897934ca.1682333574.git.baruch@tkos.co.il/

FYI,
baruch

> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> v2:
>
>   Split the translation update to a separate patch
> ---
>  Documentation/devicetree/usage-model.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/usage-model.rst b/Documentation/devicetree/usage-model.rst
> index b6a287955ee5..0717426856b2 100644
> --- a/Documentation/devicetree/usage-model.rst
> +++ b/Documentation/devicetree/usage-model.rst
> @@ -415,6 +415,6 @@ When using the DT, this creates problems for of_platform_populate()
>  because it must decide whether to register each node as either a
>  platform_device or an amba_device.  This unfortunately complicates the
>  device creation model a little bit, but the solution turns out not to
> -be too invasive.  If a node is compatible with "arm,amba-primecell", then
> +be too invasive.  If a node is compatible with "arm,primecell", then
>  of_platform_populate() will register it as an amba_device instead of a
>  platform_device.

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

Re: [PATCH v2 2/2] docs: zh_CN/devicetree: sync usage-model fix

[Yanteng Si]

在 4/24/23 18:52, Baruch Siach 写道:
> Sync compatibly string fix from the English document.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Reviewed-by: Yanteng Si <siyanteng@loongson.cn>


Thanks,

Yanteng

> ---
> v2:
>
>    New separate patch for translation
> ---
>   Documentation/translations/zh_CN/devicetree/usage-model.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/translations/zh_CN/devicetree/usage-model.rst b/Documentation/translations/zh_CN/devicetree/usage-model.rst
> index c6aee82c7e6e..19ba4ae0cd81 100644
> --- a/Documentation/translations/zh_CN/devicetree/usage-model.rst
> +++ b/Documentation/translations/zh_CN/devicetree/usage-model.rst
> @@ -325,6 +325,6 @@ Primecell设备。然而，棘手的一点是，AMBA总线上的所有设备并
>   
>   当使用DT时，这给of_platform_populate()带来了问题，因为它必须决定是否将
>   每个节点注册为platform_device或amba_device。不幸的是，这使设备创建模型
> -变得有点复杂，但解决方案原来并不是太具有侵略性。如果一个节点与“arm,amba-primecell”
> +变得有点复杂，但解决方案原来并不是太具有侵略性。如果一个节点与“arm,primecell”
>   兼容，那么of_platform_populate()将把它注册为amba_device而不是
>   platform_device。

Re: [PATCH v2 1/2] docs: dt: fix documented Primecell compatible string

[Krzysztof Kozlowski]

On 25/04/2023 10:31, Baruch Siach wrote:
> Hi Rob, Krzysztof,
> 
> On Mon, Apr 24 2023, Baruch Siach wrote:
>> Only arm,primecell is documented as compatible string for Primecell
>> peripherals. Current code agrees with that.
> 
> Once again my patches do not show up in patchwork. But they do show in
> lore:
> 
>   https://lore.kernel.org/linux-devicetree/9e137548c4e76e0d8deef6d49460cb37897934ca.1682333574.git.baruch@tkos.co.il/
> 

You used subject prefix which targets Doc subsystem, but did not Cc Doc
maintainers (get_maintainers do not print them). If you target Rob's
Patchwork, probably you need to fix subject prefix. There is no "dt" prefix.

Best regards,
Krzysztof

Re: [PATCH v2 1/2] docs: dt: fix documented Primecell compatible string

[Baruch Siach]

Hi Krzysztof,

On Mon, May 01 2023, Krzysztof Kozlowski wrote:
> On 25/04/2023 10:31, Baruch Siach wrote:
>> On Mon, Apr 24 2023, Baruch Siach wrote:
>>> Only arm,primecell is documented as compatible string for Primecell
>>> peripherals. Current code agrees with that.
>> 
>> Once again my patches do not show up in patchwork. But they do show in
>> lore:
>> 
>>   https://lore.kernel.org/linux-devicetree/9e137548c4e76e0d8deef6d49460cb37897934ca.1682333574.git.baruch@tkos.co.il/
>
> You used subject prefix which targets Doc subsystem, but did not Cc Doc
> maintainers (get_maintainers do not print them). If you target Rob's
> Patchwork, probably you need to fix subject prefix. There is no "dt" prefix.

Thanks for the tip.

All previous commits touching Documentation/devicetree/usage-model.rst
use 'docs' for subject prefix, including one from Rob. I followed this
example.

As for patchwork, I believe you refer to this one

  http://patchwork.ozlabs.org/project/devicetree-bindings/list/

Not all patches on the list use dt-bindings for subject prefix. For
example

  http://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230317053415.2254616-2-frowand.list@gmail.com/

The DT submitting-patches document
(Documentation/devicetree/bindings/submitting-patches.rst) mentions the
dt-bindings subject prefix rule. But this patch does not touch binding
documentation.

Is there anything I should do differently to get this patch applied?

Thanks,
baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

Re: [PATCH v2 1/2] docs: dt: fix documented Primecell compatible string

[Krzysztof Kozlowski]

On 01/05/2023 12:01, Baruch Siach wrote:
> Hi Krzysztof,
> 
> On Mon, May 01 2023, Krzysztof Kozlowski wrote:
>> On 25/04/2023 10:31, Baruch Siach wrote:
>>> On Mon, Apr 24 2023, Baruch Siach wrote:
>>>> Only arm,primecell is documented as compatible string for Primecell
>>>> peripherals. Current code agrees with that.
>>>
>>> Once again my patches do not show up in patchwork. But they do show in
>>> lore:
>>>
>>>   https://lore.kernel.org/linux-devicetree/9e137548c4e76e0d8deef6d49460cb37897934ca.1682333574.git.baruch@tkos.co.il/
>>
>> You used subject prefix which targets Doc subsystem, but did not Cc Doc
>> maintainers (get_maintainers do not print them). If you target Rob's
>> Patchwork, probably you need to fix subject prefix. There is no "dt" prefix.
> 
> Thanks for the tip.
> 
> All previous commits touching Documentation/devicetree/usage-model.rst
> use 'docs' for subject prefix, including one from Rob. I followed this
> example.

Hm, I see Rob and others indeed used "dt:". I guess Rob's filters might
need some updates?


Best regards,
Krzysztof

Re: [PATCH v2 1/2] docs: dt: fix documented Primecell compatible string

[Baruch Siach]

Hi Krzysztof,

On Mon, May 01 2023, Krzysztof Kozlowski wrote:
> On 01/05/2023 12:01, Baruch Siach wrote:
>> On Mon, May 01 2023, Krzysztof Kozlowski wrote:
>>> On 25/04/2023 10:31, Baruch Siach wrote:
>>>> On Mon, Apr 24 2023, Baruch Siach wrote:
>>>>> Only arm,primecell is documented as compatible string for Primecell
>>>>> peripherals. Current code agrees with that.
>>>>
>>>> Once again my patches do not show up in patchwork. But they do show in
>>>> lore:
>>>>
>>>>   https://lore.kernel.org/linux-devicetree/9e137548c4e76e0d8deef6d49460cb37897934ca.1682333574.git.baruch@tkos.co.il/
>>>
>>> You used subject prefix which targets Doc subsystem, but did not Cc Doc
>>> maintainers (get_maintainers do not print them). If you target Rob's
>>> Patchwork, probably you need to fix subject prefix. There is no "dt" prefix.
>> 
>> Thanks for the tip.
>> 
>> All previous commits touching Documentation/devicetree/usage-model.rst
>> use 'docs' for subject prefix, including one from Rob. I followed this
>> example.
>
> Hm, I see Rob and others indeed used "dt:". I guess Rob's filters might
> need some updates?

With the merge window behind us, is there anything more I need to do to
get these trivial patches applied?

Thanks,
baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

Re: [PATCH v2 1/2] docs: dt: fix documented Primecell compatible string

[Rob Herring]

On Tue, May 09, 2023 at 11:36:18AM +0300, Baruch Siach wrote:
> Hi Krzysztof,
> 
> On Mon, May 01 2023, Krzysztof Kozlowski wrote:
> > On 01/05/2023 12:01, Baruch Siach wrote:
> >> On Mon, May 01 2023, Krzysztof Kozlowski wrote:
> >>> On 25/04/2023 10:31, Baruch Siach wrote:
> >>>> On Mon, Apr 24 2023, Baruch Siach wrote:
> >>>>> Only arm,primecell is documented as compatible string for Primecell
> >>>>> peripherals. Current code agrees with that.
> >>>>
> >>>> Once again my patches do not show up in patchwork. But they do show in
> >>>> lore:
> >>>>
> >>>>   https://lore.kernel.org/linux-devicetree/9e137548c4e76e0d8deef6d49460cb37897934ca.1682333574.git.baruch@tkos.co.il/
> >>>
> >>> You used subject prefix which targets Doc subsystem, but did not Cc Doc
> >>> maintainers (get_maintainers do not print them). If you target Rob's
> >>> Patchwork, probably you need to fix subject prefix. There is no "dt" prefix.
> >> 
> >> Thanks for the tip.
> >> 
> >> All previous commits touching Documentation/devicetree/usage-model.rst
> >> use 'docs' for subject prefix, including one from Rob. I followed this
> >> example.
> >
> > Hm, I see Rob and others indeed used "dt:". I guess Rob's filters might
> > need some updates?
> 
> With the merge window behind us, is there anything more I need to do to
> get these trivial patches applied?

Sorry about this. There's a few things that PW doesn't capture and this 
is one of them. And then I've been out the last month.

Both applied now.

Rob