From: Donald Hunter <donald.hunter@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: bpf@vger.kernel.org, linux-doc@vger.kernel.org,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH bpf-next v1] docs/bpf: Add missing BPF program types to docs
Date: Thu, 12 Sep 2024 09:43:56 +0100 [thread overview]
Message-ID: <m21q1pb6sz.fsf@gmail.com> (raw)
In-Reply-To: <CAEf4Bzbo=vNwn329eBcX5oqYmQBq1DxcxubFk4D6HQmXHRFD7w@mail.gmail.com> (Andrii Nakryiko's message of "Wed, 11 Sep 2024 13:44:17 -0700")
Andrii Nakryiko <andrii.nakryiko@gmail.com> writes:
>>
>> +.. [#struct_ops] The ``struct_ops`` attach format is ``struct_ops[.s]/<name>``, but name appears
>> + to be ignored. The attachments are defined in a struct initializer that is
>> + tagged with ``SEC(".struct_ops[.link]")``.
>
> libbpf will happily accept just SEC("struct_ops"). So it would be more
> correct to say that "struct_ops[.s]/<name>" is accepted, but name is
> ignored. But other than that, just SEC("struct_ops") probably makes
> most sense.
I'll reword to recommend SEC("struct_ops"), thanks!
prev parent reply other threads:[~2024-09-12 8:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 14:59 [PATCH bpf-next v1] docs/bpf: Add missing BPF program types to docs Donald Hunter
2024-09-11 20:44 ` Andrii Nakryiko
2024-09-12 8:43 ` Donald Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m21q1pb6sz.fsf@gmail.com \
--to=donald.hunter@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=linux-doc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).