From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.secunet.com (mx1.secunet.com [62.96.220.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F07843845A4; Tue, 8 Sep 2026 06:49:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.96.220.36 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788850172; cv=none; b=M4192kFR/mBMy5DFDy8mkMYCYRNk1gnlouexVzh0PxYsADDhE+xngZhPesXuE7KDuLgiOtORyE++pPL4fax+3rYorblajQT9tiadpLZYC8YV7Dcrr4YkNhOkJdAkjqDspu+7cBO9QxrOVhALBrguHvwAX6v7V1WkWmoB5nIfbJw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788850172; c=relaxed/simple; bh=tiAYAvR1QYd1IZYryXNKs6hYmPsrTGgr1WQBUbUqZRM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WqQBTd2hdMF2Wk00SH4p//h53iWE2gcH67BwxhjqZoR1tEH9FIPk/rpcnmYqtwnAUY/X93O3+XjDtOA2NTZPNH2S05l2FffITte0Sqz9d5pvxVJBMgL/rEXmVobeHwN1FYUHbkTKLco3m6XfNMJT8qvO4nnEuGiLj01PI7qnD94= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=secunet.com; spf=pass smtp.mailfrom=secunet.com; dkim=pass (2048-bit key) header.d=secunet.com header.i=@secunet.com header.b=ns54JNh5; arc=none smtp.client-ip=62.96.220.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=secunet.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=secunet.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=secunet.com header.i=@secunet.com header.b="ns54JNh5" Received: from localhost (localhost [127.0.0.1]) by mx1.secunet.com (Postfix) with ESMTP id B10FF206DF; Tue, 8 Sep 2026 08:49:29 +0200 (CEST) X-Virus-Scanned: by secunet Received: from mx1.secunet.com ([127.0.0.1]) by localhost (mx1.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TwcW79IWxLrP; Tue, 8 Sep 2026 08:49:29 +0200 (CEST) Received: from EXCH-02.secunet.de (rl2.secunet.de [10.32.0.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.secunet.com (Postfix) with ESMTPS id 32D47204D9; Tue, 8 Sep 2026 08:49:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.secunet.com 32D47204D9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secunet.com; s=202301; t=1788850169; bh=H3I55tJOyAusyHBnFUqnTqeigM7Fj3ckzMXFybOjMms=; h=From:To:CC:Subject:Date:In-Reply-To:References:From; b=ns54JNh5wJO5HMeplodtxe+oT8sBx89x+ixv87FCcdnAEmnFZAybMTBs7FL1JOyQ0 aM33pVLWKxm7lfEICdFmna4raY+SxRWPdE8ccXsNamvcPZdFK3vAnA+obXnA/WwArd KgNgbK9MX7XdMEqwj9eeFLExPQNKvfx6WahnIkQWxactU1mlb/ON8AWeHL2nZd37cj qLF/1YswFSs5CUWKI+iGUHuxrRrGnSwOpXylebNKt9aOcTeB5rRBa+9zME7T4mFlvP makz6HDm/YUHIKn7HoDR/TPM8co5/i5pSJTNbPOAO+ozxxBekdtTOauectw5P+aiuJ 3fkugYMceZqxA== Received: from moon.secunet.de (172.18.149.1) by EXCH-02.secunet.de (10.32.0.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 8 Sep 2026 08:49:27 +0200 From: Antony Antony To: Antony Antony , Steffen Klassert , Herbert Xu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , David Ahern , Jamal Hadi Salim , Shuah Khan CC: Sabrina Dubroca , , Yan Yan , Tobias Brunner , Florian Westphal , , , Sashiko Subject: [PATCH ipsec v2 2/6] xfrm: fix use-after-free of migrated state in xfrm_do_migrate_state() Date: Tue, 8 Sep 2026 08:49:18 +0200 Message-ID: X-Mailer: git-send-email 2.39.5 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.16-dev Content-Transfer-Encoding: 8bit X-ClientProxiedBy: EXCH-04.secunet.de (10.32.0.184) To EXCH-02.secunet.de (10.32.0.172) A concurrent delete can free the migrated state before xfrm_do_migrate_state() finishes using it. Fixes: a9d155ea9b44 ("xfrm: add XFRM_MSG_MIGRATE_STATE for single SA migration") Reported-by: Sashiko Signed-off-by: Antony Antony --- net/xfrm/xfrm_user.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c index fffce22389e8..48b8a0af95e2 100644 --- a/net/xfrm/xfrm_user.c +++ b/net/xfrm/xfrm_user.c @@ -3479,6 +3479,7 @@ static int xfrm_do_migrate_state(struct sk_buff *skb, struct nlmsghdr *nlh, __xfrm_state_delete(x); spin_unlock_bh(&x->lock); + xfrm_state_hold(xc); err = xfrm_state_migrate_install(x, xc, &m, extack); if (err < 0) { /* @@ -3486,6 +3487,7 @@ static int xfrm_do_migrate_state(struct sk_buff *skb, struct nlmsghdr *nlh, * free under xfrm_cfg_mutex. Both SAs are gone if it does; * restoring x would risk SN/IV reuse. */ + xfrm_state_put(xc); goto out; } @@ -3504,6 +3506,7 @@ static int xfrm_do_migrate_state(struct sk_buff *skb, struct nlmsghdr *nlh, err = 0; } + xfrm_state_put(xc); out: xfrm_state_put(x); return err; -- 2.47.3