From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f54.google.com (mail-ua1-f54.google.com [209.85.222.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D893C48DB41 for ; Fri, 16 Oct 2026 18:19:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792174783; cv=none; b=MCh6k9f1qKmJvTzWJYBQz3vOwWpbBcBH0toX9VaF2qB/RlM8LULgsxWnwon3KUoa8deIBnsWe9A73qQhfd4Ttr/Ou8xv2MjbW1Krx1xrbRLat4tjM/63SZRa83qsEM0xJ/FsLm75IIZB5Fc27O8hP8VwA1vHWtT74e/W8zOZCMk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792174783; c=relaxed/simple; bh=7oz8HPvheVIvTGYESdpSdhYdJVJsRJpxnpOPaR0bQ90=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=oh7j7HfGjwa2UY3y07VOrr+hs6ugkqmb0cmJMWbKwCwkgW23XDK2QE5SmQJLQp5JYMGztSCN8CvGjVkipRuIDPlJs6g3aw7deLM6MBuUtsc+XIxepOAI+rykU8LKzv6Y/FMTMp8mAe2fm9eSdQXyMWkoTvbLZ8KYs0m0ftT5tww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NmoWLcYf; arc=none smtp.client-ip=209.85.222.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NmoWLcYf" Received: by mail-ua1-f54.google.com with SMTP id a1e0cc1a2514c-98c7798ce74so72426241.1 for ; Fri, 16 Oct 2026 11:19:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792174781; x=1792779581; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:subject :references:in-reply-to:message-id:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to:content-type; bh=RVF+KNTB3PtvNAoY46w+x0vdrM5zplysVyH1LA9K07M=; b=NmoWLcYfRo52mtDN875V+tDOnyXSuBV3EEenqQ4VK54P3YmJhCTmp/tBwwRZYumSD9 x/e5moJsq8QENUOzQNdUXdx6HTaIYYH2aC3U8siN+npNX+OEl0W6l+xwPVycqrS6kLPr JxIYzUxBXj4TL5QF2SKB587vTjgB0WpPHKnDqZE9a/TruClb465zuRRUmvd2H4wxvvWZ yxrtjFIH4TEbaCC4xTcSqYC6mwWtIyrABsMKS/SmxXGOGpKrjBuQdCkQ4pkDjFsZUVy3 Uhia4+QxkRAGjSl6+ZJ5YfXGWuHd5XYp1C0c2lBZp+gMFEs0O4IEe3lKg/N6RxfYZD1f x4Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792174781; x=1792779581; h=content-transfer-encoding:content-type:mime-version:subject :references:in-reply-to:message-id:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=RVF+KNTB3PtvNAoY46w+x0vdrM5zplysVyH1LA9K07M=; b=zGyJEZTuK7JoExhiiQIxcjsgY6pofQ8BYYaFxKtZakMNLOp9kfsAwtOPmDOkYUwAoo 1iuVmyGofSgYE0h0Y8WtZjuTYskablakuuKSMgWNEMMf7n17yyEufzMr+WL4ISIANmxL 38sp8V0tM9UTi3m8Qhjk7qB1zyKvH2FnfpN5z6QqS1hgLMV8btSdWRWBUtPkfpN3XLVi NgRqFaMlykdezrM5WOTrJKNbIabKtT2URqe+W1iFyM3J+dcN4vzRblX+tKuNt7WovOuQ MXhmwWWFUq0joc5sNfI39J+ipNlWFoGMIj+fh8WVIVT5bDh94oLTxiBDcMig6sz7bk+8 Ib/A== X-Forwarded-Encrypted: i=1; AKwUvBzuaUNT/V0m1upSLCWOKhmp4OnvUoqIrJxTFDJ4GxKZgDREQpRNPC0zb+DYF8JLc0KJTkuHRx2TgrI=@vger.kernel.org X-Gm-Message-State: AFq9FYJ1OvyVOcnaj9T3/nOF6FNsdF6PCJd8AtSJvSV/yh87p8pMcdy4 13NYwVOD21AhiDrbqGpr8Eor+uJ9zLXCTWSNcLOejx4JfuD3MWbDEUe4 X-Gm-Gg: AYBFou2BgSmDfL40g7WDkGiE6be4FQPoUUWUUY8BhJVYpCb0Xqli4HQUsb6lw9li9ud 8e+c15dWDr1NY4jZmDwGdWUs8vWY9Xvko7JtGeT8Z+psXCnPMEuMWA7FicIylF5nAWoUH0rpYIp jUHL9CJxT+I17w4g2gWuG6+vh/DKjdANNxKHN7hnou7AD3mwNUm103HHarmn6nw2Yf1tu9ftDor LpAG66w+EAXgfpAj+kRb2m+5XSNCHU/dYjPgCWWkgI4VwJFa8D3XGzdXTiN7SVuJ3oph1VrlFgf E+6ImnAeF+1SqBQBw5OMTJM3ShiUfpjJAWl2AgkPqwbRGwa1fBcYTwSML9XhkxS74bC0m5dYtgx 2dNf/o5MgxpfYa1DlOSUGJT5bTY2q4DiXSs5ddvKox3qE67O14VJzSucz/pq0qL49z671+DOKee bqRowuNni4+2W8feOCa02q2cFzKLpGnSYO7RT6DttmAleFslu6Pkfz36JEEKkPJId6+g8k4RjsZ fbVpjTeuZ1AH4CYNE7WBQQ+k1xks1UB5NLGKNzU565EvgG+4TCQ9BgIpZuS6nQqr+v4KyStpUML 2s+stLdhHPJYo6bd0LBH+4kEvt/DKVbs4gNJZN1TMOG6DXcQHA== X-Received: by 2002:a05:6102:419e:b0:7c3:2f33:54bb with SMTP id ada2fe7eead31-7cc36aa3d6bmr96424137.28.1792174780679; Fri, 16 Oct 2026 11:19:40 -0700 (PDT) Received: from gmail.com (111.46.245.35.bc.googleusercontent.com. [35.245.46.111]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-990835c253csm2173395241.5.2026.10.16.11.19.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Oct 2026 11:19:40 -0700 (PDT) Date: Fri, 16 Oct 2026 14:19:39 -0400 From: Willem de Bruijn To: "Michael S. Tsirkin" , Willem de Bruijn Cc: linux-kernel@vger.kernel.org, Jason Wang , =?UTF-8?B?RXVnZW5pbyBQw6lyZXo=?= , Xuan Zhuo , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, virtualization@lists.linux.dev, Rusty Russell , Max Krasnyansky , Jonathan Corbet , Shuah Khan , Randy Dunlap , Simon Horman , linux-doc@vger.kernel.org Message-ID: In-Reply-To: <20261016134823-mutt-send-email-mst@kernel.org> References: <20261016051827-mutt-send-email-mst@kernel.org> <20261016134823-mutt-send-email-mst@kernel.org> Subject: Re: [PATCH net-next v2 5/7] net: add a sysctl to opt out of virtio net hdr checksum validation Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Michael S. Tsirkin wrote: > On Fri, Oct 16, 2026 at 11:30:17AM -0400, Willem de Bruijn wrote: > > Michael S. Tsirkin wrote: > > > On Thu, Oct 15, 2026 at 01:50:54PM -0400, Willem de Bruijn wrote: > > > > Michael S. Tsirkin wrote: > > > > > The ingress validation as implemented by the previous > > > > > patch is stricter than what it replaced: GSO > > > > > packets whose checksum metadata matches no transport header are > > > > > dropped, and non-GSO ones get their checksum completed in place. > > > > > Such packets used to pass with the metadata unvalidated, > > > > > and with no overhead. > > > > > > > > > > I judge that this should not affect any deployments, but there is still > > > > > some risk that it does. In case a deployment depends on them anyway, > > > > > provide a per-netns switch to get the old behavior back: > > > > > > > > > > echo 0 > /proc/sys/net/core/virtio_net_hdr_csum_check > > > > > > > > > > The default is validating. > > > > > > > > > > Assisted-by: LLM > > > > > Signed-off-by: Michael S. Tsirkin > > > > > --- > > > > > Documentation/admin-guide/sysctl/net.rst | 15 +++++++ > > > > > include/linux/virtio_net.h | 23 ++++++++++ > > > > > include/net/netns/core.h | 1 + > > > > > net/core/dev.c | 6 +++ > > > > > net/core/net_namespace.c | 1 + > > > > > net/core/sysctl_net_core.c | 54 ++++++++++++++++++++++++ > > > > > 6 files changed, 100 insertions(+) > > > > > > > > > > diff --git a/Documentation/admin-guide/sysctl/net.rst b/Documentation/admin-guide/sysctl/net.rst > > > > > index e586e17fc7a5..7f230929c37e 100644 > > > > > --- a/Documentation/admin-guide/sysctl/net.rst > > > > > +++ b/Documentation/admin-guide/sysctl/net.rst > > > > > @@ -246,6 +246,21 @@ processes are dropped unless socket option SOF_TIMESTAMPING_OPT_TSONLY is set. > > > > > Default: 1 (on) > > > > > > > > > > > > > > > +virtio_net_hdr_csum_check > > > > > +------------------------- > > > > > > > > Make more generic, virtio_net_hdr_validate? > > > > > > > > In case we add more validation in the future (as we have in the past), > > > > without having to introduce multiple such knobs. > > > > > > But it's uapi, are you sure we'll be able to change the meaning > > > of an existing knob, even if we keep the name vague? > > > > > > > > + > > > > > +When processing packets with a virtio net header (through tun, tap, a > > > > > +packet socket or a virtio network device) that request checksum offload > > > > > +(VIRTIO_NET_HDR_F_NEEDS_CSUM), validate the packet: complete the checksum > > > > > +in software, or drop the packet where the header does not match it. > > > > > + > > > > > +When disabled, the header is trusted not to corrupt the packet, and the > > > > > +checksum is offloaded to hardware (or not verified if it never reaches > > > > > +hardware). This is only safe if no protocol is processing the packets. > > > > > + > > > > > +Default: 1 (on) > > > > > + > > > > > + > > > > > wmem_default > > > > > ------------ > > > > > > > > > > diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h > > > > > index 357115ff0ec2..aa2f8ac4657c 100644 > > > > > --- a/include/linux/virtio_net.h > > > > > +++ b/include/linux/virtio_net.h > > > > > @@ -5,6 +5,7 @@ > > > > > #include > > > > > #include > > > > > #include > > > > > +#include > > > > > #include > > > > > #include > > > > > #include > > > > > @@ -78,6 +79,19 @@ static inline struct iphdr *virtio_net_ip4_parse(struct sk_buff *skb, > > > > > *thoff = nhoff + iph->ihl * sizeof(u32); > > > > > return iph; > > > > > } > > > > > +/* Defined in net/core/dev.c, enabled while any network namespace > > > > > + * has net.core.virtio_net_hdr_csum_check set to 0. > > > > > + */ > > > > > > > > Should this be a global sysctl, rather than per netns? > > > > > > > > > For customers I work with, it would be much less useful. > > > > Third option: make it an integer rather than a boolean. > > > > 0: no validation > > 1: current level of validation > > 2 and beyond: if we have to extend it later > > > > Not pretty, I'll admit. So fine to keep as is too if you prefer. > > But I do foresee more changes in this area, if history is a guide. > > > > > > > > > Even if per-netns, most likely do not want it writable by netns root > > > > with user namespaces. > > > > > > > > That is the equivalent of ns_capable(CAP_NET_RAW), which is the cause > > > > of many crashes due to bad packets ingested by, e.g., a packet socket. > > > > > > Hmm, yes i get that. Two knobs? a. verify b. the per netns value ro? Both > > > on by default? > > > > A single system wide field is simplest. > > > > Is there a benefit to making this configurable on a per netns basis? > > As I tried to explain: a specific container breaks, you decide to trust it, > you do not need to trust all. Ok > > If so, that's fine too. As long as root-in-namespace cannot modify it, > > so readonly indeed. > > > Right. So I envision along the lines of: > > net.core.virtio_net_hdr_validate_all - validate packets from any netns, > netns root can not change it, only host root > > net.core.virtio_net_hdr_validate - per netns Then skip the global option, as it's just a convenience: the same can be achieved by iterating over all the per-netns settings. Per netns validation, but only settable by root, not by root-in-namespace.