linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] scsi: docs: clean up some style in scsi_mid_low_api
@ 2025-05-02  1:51 Randy Dunlap
  2025-05-06  2:32 ` Martin K. Petersen
  2025-05-13  2:48 ` Martin K. Petersen
  0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2025-05-02  1:51 UTC (permalink / raw)
  To: linux-kernel
  Cc: Randy Dunlap, James E.J. Bottomley, Martin K. Petersen,
	linux-scsi, Jonathan Corbet, linux-doc

Capitalize Linux but not "kernel."
Spell out Linux instead of using "lk".
Hyphenate "system-wide."
Hyphenate "32-bit".
End a sentence with a period (full stop).
Change "double linked" to "doubly linked" list.
Use SCSI or scsi but not Scsi.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org
---
 Documentation/scsi/scsi_mid_low_api.rst |   18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

--- linux-next-20250501.orig/Documentation/scsi/scsi_mid_low_api.rst
+++ linux-next-20250501/Documentation/scsi/scsi_mid_low_api.rst
@@ -37,7 +37,7 @@ ISA adapters).]
 The SCSI mid level isolates an LLD from other layers such as the SCSI
 upper layer drivers and the block layer.
 
-This version of the document roughly matches linux kernel version 2.6.8 .
+This version of the document roughly matches Linux kernel version 2.6.8 .
 
 Documentation
 =============
@@ -48,7 +48,7 @@ found in that directory. A more recent c
 at https://docs.kernel.org/scsi/scsi_mid_low_api.html. Many LLDs are
 documented in Documentation/scsi (e.g. aic7xxx.rst). The SCSI mid-level is
 briefly described in scsi.rst which contains a URL to a document describing
-the SCSI subsystem in the Linux Kernel 2.4 series. Two upper level
+the SCSI subsystem in the Linux kernel 2.4 series. Two upper level
 drivers have documents in that directory: st.rst (SCSI tape driver) and
 scsi-generic.rst (for the sg driver).
 
@@ -75,7 +75,7 @@ It is probably best to study how existin
 As the 2.5 series development kernels evolve into the 2.6 series
 production series, changes are being introduced into this interface. An
 example of this is driver initialization code where there are now 2 models
-available. The older one, similar to what was found in the lk 2.4 series,
+available. The older one, similar to what was found in the Linux 2.4 series,
 is based on hosts that are detected at HBA driver load time. This will be
 referred to the "passive" initialization model. The newer model allows HBAs
 to be hot plugged (and unplugged) during the lifetime of the LLD and will
@@ -1026,7 +1026,7 @@ initialized from the driver's struct scs
 of interest:
 
     host_no
-		 - system wide unique number that is used for identifying
+		 - system-wide unique number that is used for identifying
                    this host. Issued in ascending order from 0.
     can_queue
 		 - must be greater than 0; do not send more than can_queue
@@ -1053,7 +1053,7 @@ of interest:
 		 - pointer to driver's struct scsi_host_template from which
                    this struct Scsi_Host instance was spawned
     hostt->proc_name
-		 - name of LLD. This is the driver name that sysfs uses
+		 - name of LLD. This is the driver name that sysfs uses.
     transportt
 		 - pointer to driver's struct scsi_transport_template instance
                    (if any). FC and SPI transports currently supported.
@@ -1067,7 +1067,7 @@ The scsi_host structure is defined in in
 struct scsi_device
 ------------------
 Generally, there is one instance of this structure for each SCSI logical unit
-on a host. Scsi devices connected to a host are uniquely identified by a
+on a host. SCSI devices connected to a host are uniquely identified by a
 channel number, target id and logical unit number (lun).
 The structure is defined in include/scsi/scsi_device.h
 
@@ -1091,7 +1091,7 @@ Members of interest:
 		 - should be set by LLD prior to calling 'done'. A value
                    of 0 implies a successfully completed command (and all
                    data (if any) has been transferred to or from the SCSI
-                   target device). 'result' is a 32 bit unsigned integer that
+                   target device). 'result' is a 32-bit unsigned integer that
                    can be viewed as 2 related bytes. The SCSI status value is
                    in the LSB. See include/scsi/scsi.h status_byte() and
                    host_byte() macros and related constants.
@@ -1180,8 +1180,8 @@ may get out of synchronization. This is
 to perform autosense.
 
 
-Changes since lk 2.4 series
-===========================
+Changes since Linux kernel 2.4 series
+=====================================
 io_request_lock has been replaced by several finer grained locks. The lock
 relevant to LLDs is struct Scsi_Host::host_lock and there is
 one per SCSI host.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: docs: clean up some style in scsi_mid_low_api
  2025-05-02  1:51 [PATCH] scsi: docs: clean up some style in scsi_mid_low_api Randy Dunlap
@ 2025-05-06  2:32 ` Martin K. Petersen
  2025-05-13  2:48 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2025-05-06  2:32 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: linux-kernel, James E.J. Bottomley, Martin K. Petersen,
	linux-scsi, Jonathan Corbet, linux-doc


Randy,

> Capitalize Linux but not "kernel."
> Spell out Linux instead of using "lk".
> Hyphenate "system-wide."
> Hyphenate "32-bit".
> End a sentence with a period (full stop).
> Change "double linked" to "doubly linked" list.
> Use SCSI or scsi but not Scsi.

Applied to 6.16/scsi-staging, thanks!

-- 
Martin K. Petersen

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: docs: clean up some style in scsi_mid_low_api
  2025-05-02  1:51 [PATCH] scsi: docs: clean up some style in scsi_mid_low_api Randy Dunlap
  2025-05-06  2:32 ` Martin K. Petersen
@ 2025-05-13  2:48 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2025-05-13  2:48 UTC (permalink / raw)
  To: linux-kernel, Randy Dunlap
  Cc: Martin K . Petersen, James E.J. Bottomley, linux-scsi,
	Jonathan Corbet, linux-doc

On Thu, 01 May 2025 18:51:36 -0700, Randy Dunlap wrote:

> Capitalize Linux but not "kernel."
> Spell out Linux instead of using "lk".
> Hyphenate "system-wide."
> Hyphenate "32-bit".
> End a sentence with a period (full stop).
> Change "double linked" to "doubly linked" list.
> Use SCSI or scsi but not Scsi.
> 
> [...]

Applied to 6.16/scsi-queue, thanks!

[1/1] scsi: docs: clean up some style in scsi_mid_low_api
      https://git.kernel.org/mkp/scsi/c/73349697fd99

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-05-13  2:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-02  1:51 [PATCH] scsi: docs: clean up some style in scsi_mid_low_api Randy Dunlap
2025-05-06  2:32 ` Martin K. Petersen
2025-05-13  2:48 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).