From: wufan <wufan@codeaurora.org>
To: 'Tyler Baicar' <baicar.tyler@gmail.com>
Cc: mchehab@kernel.org, 'Borislav Petkov' <bp@alien8.de>,
'James Morse' <james.morse@arm.com>,
linux-edac@vger.kernel.org,
'Linux Kernel Mailing List' <linux-kernel@vger.kernel.org>,
'arm-mail-list' <linux-arm-kernel@lists.infradead.org>,
john.garry@huawei.com, toshi.kani@hpe.com
Subject: [v2] EDAC, ghes: use CPER module handles to locate DIMMs
Date: Thu, 30 Aug 2018 13:45:19 -0600 [thread overview]
Message-ID: <001901d44099$fc8d7550$f5a85ff0$@codeaurora.org> (raw)
Hi Tyler,
> > +static int get_dimm_smbios_index(u16 handle) {
> > + struct mem_ctl_info *mci;
> > + int i;
> > +
> > + mci = ghes_pvt->mci;
> > +
>
> Minor nit: you could define and set mci in the same line to save some space
> here.
>
> Otherwise this patch looks good to me.
Good catch Tyler! I'll fix it.
Thanks,
Fan
> Reviewed-by: Tyler Baicar <baicar.tyler@gmail.com>
next reply other threads:[~2018-08-30 19:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 19:45 wufan [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-08-30 21:29 [v2] EDAC, ghes: use CPER module handles to locate DIMMs Toshi Kani
2018-08-30 19:18 Tyler Baicar
2018-08-30 18:37 wufan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001901d44099$fc8d7550$f5a85ff0$@codeaurora.org' \
--to=wufan@codeaurora.org \
--cc=baicar.tyler@gmail.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=john.garry@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=toshi.kani@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).