Re: [PATCH RFC 0/6] x86/msr: Rename MSR access functions

Peter Zijlstra
2026-04-20T11:41:28Z

On Mon, Apr 20, 2026 at 01:35:12PM +0200, Peter Zijlstra wrote:
> On Mon, Apr 20, 2026 at 11:16:28AM +0200, Juergen Gross wrote:
>
> > - Use functions instead of macros for accessing MSRs, which will drop
> > modifying variables passed as a parameter.
> >
> > - Eliminate multiple accessors doing exactly the same thing (e.g.
> > rdmsrl() and rdmsrq()).
>
> So far so sane.
>
> > - Instead of having function names based on the underlying instruction
> > mnemonics, have functions of a common name space (msr_*()).
>
> Not sure on this one. The whole msr_{read,write}_{safe,noser}() thing is
> a royal pain. Also 'noser' reads to me as the noun that goes with 'to
> nose' [he that noses (around), like baker: he that bakes].
>
> I would much rather we just stick to the mnemonics here. All of this
> really is about wrapping single instructions, no need to make it an
> unreadable mess.

Also, the _safe suffix should just go away. All MSR accessors should be
'safe'.