From: Peter Tyser <ptyser@xes-inc.com>
To: bluesmoke-devel@lists.sourceforge.net
Cc: Peter Tyser <ptyser@xes-inc.com>,
linuxppc-dev@ozlabs.org, djiang@mvista.com
Subject: [PATCH 2/4] edac: Fix mpc85xx page calculation
Date: Thu, 19 Nov 2009 18:42:27 -0600 [thread overview]
Message-ID: <1258677749-15968-2-git-send-email-ptyser@xes-inc.com> (raw)
In-Reply-To: <1258677749-15968-1-git-send-email-ptyser@xes-inc.com>
Commit b4846251727a38a7f248e41308c060995371dd05 accidentally broke how a
chip select's first and last page addresses are calculated. The page
addresses are being shifted too far right by PAGE_SHIFT. This results
in errors such as:
EDAC MPC85xx MC1: Err addr: 0x003075c0
EDAC MPC85xx MC1: PFN: 0x00000307
EDAC MPC85xx MC1: PFN out of range!
EDAC MC1: INTERNAL ERROR: row out of range (4 >= 4)
EDAC MC1: CE - no information available: INTERNAL ERROR
The vale of PAGE_SHIFT is already being taken into consideration during
the calculation of the 'start' and 'end' variables, thus it is not
necessary to account for it again when setting a chip select's first and
last page address.
Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
---
drivers/edac/mpc85xx_edac.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
index 28d3211..ecd5928 100644
--- a/drivers/edac/mpc85xx_edac.c
+++ b/drivers/edac/mpc85xx_edac.c
@@ -804,8 +804,8 @@ static void __devinit mpc85xx_init_csrows(struct mem_ctl_info *mci)
end <<= (24 - PAGE_SHIFT);
end |= (1 << (24 - PAGE_SHIFT)) - 1;
- csrow->first_page = start >> PAGE_SHIFT;
- csrow->last_page = end >> PAGE_SHIFT;
+ csrow->first_page = start;
+ csrow->last_page = end;
csrow->nr_pages = end + 1 - start;
csrow->grain = 8;
csrow->mtype = mtype;
--
1.6.2.1
next prev parent reply other threads:[~2009-11-20 0:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 0:42 [PATCH 1/4] edac: Remove unused mpc85xx debug code Peter Tyser
2009-11-20 0:42 ` Peter Tyser [this message]
2009-11-20 0:42 ` [PATCH 3/4] edac: Mask mpc85xx ECC syndrome appropriately Peter Tyser
2009-11-20 0:42 ` [PATCH 4/4] edac: Improve SDRAM error reporting for mpc85xx Peter Tyser
2010-01-25 17:20 ` [PATCH 1/4] edac: Remove unused mpc85xx debug code Peter Tyser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258677749-15968-2-git-send-email-ptyser@xes-inc.com \
--to=ptyser@xes-inc.com \
--cc=bluesmoke-devel@lists.sourceforge.net \
--cc=djiang@mvista.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox