From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: yazen.ghannam@amd.com, tony.luck@intel.com,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
avadhut.naik@amd.com, john.allen@amd.com, muralidhara.mk@amd.com
Subject: Re: [PATCH] RAS/AMD/ATL: Add MI300 DRAM to Normalized address translation support
Date: Thu, 1 Feb 2024 09:35:13 -0500 [thread overview]
Message-ID: <132e22b9-2e42-4d8d-a2ea-14023bd5dae1@amd.com> (raw)
In-Reply-To: <20240201092148.GBZbtirOfNAR3SYmht@fat_crate.local>
On 2/1/2024 4:21 AM, Borislav Petkov wrote:
> On Wed, Jan 31, 2024 at 10:57:32AM -0600, Yazen Ghannam wrote:
>> diff --git a/drivers/ras/amd/atl/umc.c b/drivers/ras/amd/atl/umc.c
>> index 7bfa21a582f0..816c2c5c683f 100644
>> --- a/drivers/ras/amd/atl/umc.c
>> +++ b/drivers/ras/amd/atl/umc.c
>> @@ -49,6 +49,203 @@ static u8 get_coh_st_inst_id_mi300(struct atl_err *err)
>> return i;
>> }
>>
>> +static u16 internal_bitwise_xor(u16 val)
>
> Why are we calling it "internal"?
>
It's an operation on the bits within a value rather than between two values.
BTW, I looked up "internal" in a thesaurus, and nothing seemed much better to me.
Maybe something like "xor_bits_in_value()"? This has the verb-first style too.
Thanks,
Yazen
next prev parent reply other threads:[~2024-02-01 14:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 16:57 [PATCH] RAS/AMD/ATL: Add MI300 DRAM to Normalized address translation support Yazen Ghannam
2024-02-01 7:03 ` M K, Muralidhara
2024-02-01 9:21 ` Borislav Petkov
2024-02-01 14:35 ` Yazen Ghannam [this message]
2024-02-01 15:05 ` Borislav Petkov
2024-02-01 21:59 ` Yazen Ghannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=132e22b9-2e42-4d8d-a2ea-14023bd5dae1@amd.com \
--to=yazen.ghannam@amd.com \
--cc=avadhut.naik@amd.com \
--cc=bp@alien8.de \
--cc=john.allen@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=muralidhara.mk@amd.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox