From: Dinh Nguyen <dinguyen@kernel.org>
To: niravkumarlaxmidas.rabara@altera.com, bp@alien8.de, tony.luck@intel.com
Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] EDAC/altera: Use INTTEST register for Ethernet and USB SBE injection
Date: Tue, 11 Nov 2025 05:46:51 -0600 [thread overview]
Message-ID: <13bf4434-13a1-4db0-8bcf-4c52edaa68f3@kernel.org> (raw)
In-Reply-To: <20251111081333.1279635-1-niravkumarlaxmidas.rabara@altera.com>
On 11/11/25 02:13, niravkumarlaxmidas.rabara@altera.com wrote:
> From: Niravkumar L Rabara <niravkumarlaxmidas.rabara@altera.com>
>
> The current single-bit error injection mechanism flips bits directly in
> ECC RAM by performing write and read operations. When the ECC RAM is
> actively used by the Ethernet or USB controller, this approach sometimes
> trigger a false double-bit error.
>
> Switch both Ethernet and USB EDAC devices to use the INTTEST register
> (altr_edac_a10_device_inject_fops) for single-bit error injection,
> similar to the existing double-bit error injection method.
>
> Fixes: 064acbd4f4ab ("EDAC, altera: Add Stratix10 peripheral support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Niravkumar L Rabara <niravkumarlaxmidas.rabara@altera.com>
> ---
>
> v2 changes:
> - Add missing Cc tag
>
> v1 link:
> https://lore.kernel.org/all/20251101051723.917688-1-niravkumarlaxmidas.rabara@altera.com/
>
> drivers/edac/altera_edac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
> index 103b2c2eba2a..5c5d4585d8ae 100644
> --- a/drivers/edac/altera_edac.c
> +++ b/drivers/edac/altera_edac.c
Acked-by: Dinh Nguyen <dinguyen@kernel.org>
next prev parent reply other threads:[~2025-11-11 11:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 8:13 [PATCH v2] EDAC/altera: Use INTTEST register for Ethernet and USB SBE injection niravkumarlaxmidas.rabara
2025-11-11 11:46 ` Dinh Nguyen [this message]
2025-11-11 13:59 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13bf4434-13a1-4db0-8bcf-4c52edaa68f3@kernel.org \
--to=dinguyen@kernel.org \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=niravkumarlaxmidas.rabara@altera.com \
--cc=stable@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox