linux-edac.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Toshi Kani <toshi.kani@hpe.com>
To: "bp@alien8.de" <bp@alien8.de>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"lenb@kernel.org" <lenb@kernel.org>,
	"mchehab@kernel.org" <mchehab@kernel.org>,
	"tony.luck@intel.com" <tony.luck@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
	"rjw@rjwysocki.net" <rjw@rjwysocki.net>
Subject: [v2,4/7] ghes_edac: avoid multiple calls to dmi_walk()
Date: Mon, 14 Aug 2017 20:17:54 +0000	[thread overview]
Message-ID: <1502741290.2042.147.camel@hpe.com> (raw)

On Mon, 2017-08-14 at 21:34 +0200, Borislav Petkov wrote:
> On Mon, Aug 14, 2017 at 07:02:15PM +0000, Kani, Toshimitsu wrote:
> > I do not know how likely we see such case, but the code should be
> > written according to the spec.
> 
> Well, then you'll have to make ghes_edac_report_mem_error()
> reentrant. Which doesn't look that hard as the only thing it really
> needs from struct ghes_edac_pvt are those string buffers. I guess you
> can try to do the simplest thing first and allocate them on the
> stack.

ghes_edac_report_mem_error() is reentrant as it is now.  I think the
current code design of allocating mci & ghes_edac_pvt for each GHES
source entry makes sense.  edac_raw_mc_handle_error() also has the same
  expectation that the call is serialized per mci.

Thanks,
-Toshi

             reply	other threads:[~2017-08-14 20:17 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-14 20:17 Toshi Kani [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-08-21  9:29 [v2,4/7] ghes_edac: avoid multiple calls to dmi_walk() Borislav Petkov
2017-08-17 21:08 Toshi Kani
2017-08-16 18:01 Toshi Kani
2017-08-16 17:40 Borislav Petkov
2017-08-16 17:31 Borislav Petkov
2017-08-16 17:28 Toshi Kani
2017-08-16 16:42 Borislav Petkov
2017-08-16 15:26 Toshi Kani
2017-08-16 14:22 Steven Rostedt
2017-08-16 14:03 Borislav Petkov
2017-08-16 13:59 Steven Rostedt
2017-08-16 11:29 Borislav Petkov
2017-08-16  8:29 Borislav Petkov
2017-08-15 16:19 Toshi Kani
2017-08-15 15:53 Toshi Kani
2017-08-15 15:50 Borislav Petkov
2017-08-15 15:48 Luck, Tony
2017-08-15 15:35 Toshi Kani
2017-08-14 20:39 Borislav Petkov
2017-08-14 19:34 Borislav Petkov
2017-08-14 19:02 Toshi Kani
2017-08-14 18:35 Borislav Petkov
2017-08-14 18:17 Toshi Kani
2017-08-14 18:05 Borislav Petkov
2017-08-14 17:52 Toshi Kani
2017-08-14 17:05 Borislav Petkov
2017-08-14 16:48 Toshi Kani
2017-08-14 16:24 Borislav Petkov
2017-08-14 15:57 Toshi Kani
2017-08-11  9:04 Borislav Petkov
2017-08-07 17:59 Toshi Kani
2017-08-05  5:16 Borislav Petkov
2017-08-04 21:02 Toshi Kani
2017-08-04  4:05 Borislav Petkov
2017-08-03 21:57 Toshi Kani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1502741290.2042.147.camel@hpe.com \
    --to=toshi.kani@hpe.com \
    --cc=bp@alien8.de \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).