From: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
To: bp@alien8.de
Cc: tony.luck@intel.com, mchehab@osg.samsung.com,
arozansk@redhat.com, linux-edac@vger.kernel.org,
Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Subject: [v1,1/4] EDAC, skx_edac: Fix function calling order in skx_exit()
Date: Fri, 16 Nov 2018 15:33:36 +0800 [thread overview]
Message-ID: <1542353616-13421-1-git-send-email-qiuxu.zhuo@intel.com> (raw)
The order of function calling in skx_exit() is not the reversed
order in skx_init(). Fix it by calling functions in skx_exit()
in a proper order.
Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
---
drivers/edac/skx_edac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/edac/skx_edac.c b/drivers/edac/skx_edac.c
index a99ea61dad32..b23c8aaa5f2b 100644
--- a/drivers/edac/skx_edac.c
+++ b/drivers/edac/skx_edac.c
@@ -1339,11 +1339,11 @@ static void __exit skx_exit(void)
{
edac_dbg(2, "\n");
mce_unregister_decode_chain(&skx_mce_dec);
- skx_remove();
+ teardown_skx_debug();
if (nvdimm_count)
skx_adxl_put();
kfree(skx_msg);
- teardown_skx_debug();
+ skx_remove();
}
module_init(skx_init);
next reply other threads:[~2018-11-16 7:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 7:33 Qiuxu Zhuo [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-11-16 10:23 [v1,1/4] EDAC, skx_edac: Fix function calling order in skx_exit() Borislav Petkov
2018-11-16 13:28 Qiuxu Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1542353616-13421-1-git-send-email-qiuxu.zhuo@intel.com \
--to=qiuxu.zhuo@intel.com \
--cc=arozansk@redhat.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox