[PATCH -next] edac: use BIT_64() to eliminate warnings

[PATCH -next] edac: use BIT_64() to eliminate warnings

[Randy Dunlap]

From: Randy Dunlap <randy.dunlap@oracle.com>

Building for X86_32 produces shift count warnings, so use
BIT_64() to eliminate the warnings.

drivers/edac/mce_amd.c:778: warning: left shift count >= width of type
drivers/edac/mce_amd.c:778: warning: left shift count >= width of type

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Doug Thompson <dougthompson@xmission.com>
Cc: Borislav Petkov <borislav.petkov@amd.com>
Cc: bluesmoke-devel@lists.sourceforge.net
---
 drivers/edac/mce_amd.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-next-20101112.orig/drivers/edac/mce_amd.c
+++ linux-next-20101112/drivers/edac/mce_amd.c
@@ -776,8 +776,8 @@ int amd_decode_mce(struct notifier_block
 
 	if (c->x86 == 0x15)
 		pr_cont("|%s|%s",
-			((m->status & BIT(44))	? "Deferred" : "-"),
-			((m->status & BIT(43))	? "Poison"   : "-"));
+			((m->status & BIT_64(44)) ? "Deferred" : "-"),
+			((m->status & BIT_64(43)) ? "Poison"   : "-"));
 
 	/* do the two bits[14:13] together */
 	ecc = (m->status >> 45) & 0x3;

------------------------------------------------------------------------------
Centralized Desktop Delivery: Dell and VMware Reference Architecture
Simplifying enterprise desktop deployment and management using
Dell EqualLogic storage and VMware View: A highly scalable, end-to-end
client virtualization framework. Read more!
http://p.sf.net/sfu/dell-eql-dev2dev

Re: [PATCH -next] edac: use BIT_64() to eliminate warnings

[Borislav Petkov]

On Sat, Nov 13, 2010 at 11:44:26AM -0500, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Building for X86_32 produces shift count warnings, so use
> BIT_64() to eliminate the warnings.
> 
> drivers/edac/mce_amd.c:778: warning: left shift count >= width of type
> drivers/edac/mce_amd.c:778: warning: left shift count >= width of type
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Doug Thompson <dougthompson@xmission.com>
> Cc: Borislav Petkov <borislav.petkov@amd.com>
> Cc: bluesmoke-devel@lists.sourceforge.net

Thanks, applied.

BTW, Doug, we still carry the bluesmoke-devel ML as edac mailing list
in MAINTAINERS althouth there's a new linux-edac@vger... which got
proposed recently. I think we should use that new one and deprecate the
sourceforge list since the new one is not moderated for subsribers and
thus more open.

Thoughts?

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632