From: Borislav Petkov <bp@alien8.de>
To: Yazen Ghannam <Yazen.Ghannam@amd.com>
Cc: linux-edac@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [v2] x86/mce: Always save severity in machine_check_poll
Date: Thu, 22 Jun 2017 10:48:44 +0200 [thread overview]
Message-ID: <20170622084828.ojspq6zg7ee3ppfi@pd.tnic> (raw)
On Wed, Jun 21, 2017 at 02:46:42PM -0500, Yazen Ghannam wrote:
> From: Yazen Ghannam <yazen.ghannam@amd.com>
>
> The severity gives a hint as to how to handle the error. The notifier
> blocks can then use the severity to decide on an action. It's not necessary
> for machine_check_poll() to filter errors for the notifier chain, since
> each block will check its own set of conditions before handling an error.
> Also, there isn't any urgency for machine_check_poll() to make decisions
> based on severity like in do_machine_check().
>
> If we can assume that a severity is set then we can use them in more
> notifier blocks. For example, the CEC block can check for a "KEEP" severity
Hmm, I'm not sure about this. If we did this, we would have to *make*
CECCs be always KEEP severity. And they are now but doing that would
make that mapping CECC->KEEP imprecise and unnecessary but required....
Yeah, we can talk about that when we have to cross that bridge.
So I've left the example but made the above s/can/could/ :)
> rather than checking bits in the status. This isn't possible now since the
> severity is not set except for "DEFFRRED/UCNA" errors with a valid address.
>
> Save the severity since we have it, and let the notifier blocks decide if
> they want to do anything.
>
> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
> ---
> Link:
> https://lkml.kernel.org/r/1497286446-59533-1-git-send-email-Yazen.Ghannam@amd.com
>
> v1->v2:
> * Expand commit message.
>
> arch/x86/kernel/cpu/mcheck/mce.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
Applied, thanks.
next reply other threads:[~2017-06-22 8:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 8:48 Borislav Petkov [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-06-21 19:46 [v2] x86/mce: Always save severity in machine_check_poll Yazen Ghannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170622084828.ojspq6zg7ee3ppfi@pd.tnic \
--to=bp@alien8.de \
--cc=Yazen.Ghannam@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox