From: Borislav Petkov <bp@alien8.de>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: mchehab@kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: edac: constify attribute_group structures.
Date: Mon, 17 Jul 2017 10:23:24 +0200 [thread overview]
Message-ID: <20170717082324.GA23129@nazgul.tnic> (raw)
On Mon, Jul 03, 2017 at 04:09:33PM +0530, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 6026 2541 12 8579 2183 drivers/edac/edac_mc_sysfs.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 6090 2477 12 8579 2183 drivers/edac/edac_mc_sysfs.o
What is that before/after thing supposed to tell me exactly?
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/edac/edac_mc_sysfs.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Anyway, I've merged your two EDAC patches into one and applied it.
Thanks.
next reply other threads:[~2017-07-17 8:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 8:23 Borislav Petkov [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-07-03 10:39 edac: constify attribute_group structures Arvind Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170717082324.GA23129@nazgul.tnic \
--to=bp@alien8.de \
--cc=arvind.yadav.cs@gmail.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox