From: Borislav Petkov <bp@alien8.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-edac <linux-edac@vger.kernel.org>,
Tony Luck <tony.luck@intel.com>,
Yazen Ghannam <Yazen.Ghannam@amd.com>, X86 ML <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [RFC,6/8] EDAC, mce_amd: Convert to seq_buf
Date: Fri, 28 Jul 2017 09:09:33 +0200 [thread overview]
Message-ID: <20170728070933.GA1884@nazgul.tnic> (raw)
On Thu, Jul 27, 2017 at 09:47:08PM -0400, Steven Rostedt wrote:
> What happens if two CPUs have mce's at the same time? Wouldn't one
> corrupt the other buffer. 128 isn't too big to put on the stack is it?
Yeah, putting it on the stack is probably safer, just in case.
What is even better, though, is if I extended
arch/x86/kernel/cpu/mcheck/mce-genpool.c to allocate a second buffer for the
decoded strings. We use it for the struct mces right now.
And 1-2 pages should be fine:
8192 / 128 = 64 decoded strings in flight.
I guess that should cover most situations. Famous last words.
In any case, thanks for pointing this out.
next reply other threads:[~2017-07-28 7:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 7:09 Borislav Petkov [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-07-28 14:09 [RFC,6/8] EDAC, mce_amd: Convert to seq_buf Borislav Petkov
2017-07-28 12:59 Steven Rostedt
2017-07-28 10:51 Borislav Petkov
2017-07-28 1:47 Steven Rostedt
2017-07-25 15:45 Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170728070933.GA1884@nazgul.tnic \
--to=bp@alien8.de \
--cc=Yazen.Ghannam@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox