From: Borislav Petkov <bp@alien8.de>
To: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Cc: mchehab@osg.samsung.com, tony.luck@intel.com,
arozansk@redhat.com, patrickg@supermicro.com,
linux-edac@vger.kernel.org
Subject: [2/3] EDAC, pnd2: Conditionally unhide/hide the P2SB PCI device to read BAR.
Date: Sat, 19 Aug 2017 10:53:34 +0200 [thread overview]
Message-ID: <20170819085334.kafuayddf2ymum55@pd.tnic> (raw)
On Mon, Aug 14, 2017 at 11:48:45PM +0800, Qiuxu Zhuo wrote:
> On Deverton server, the P2SB PCI device(DEV:1F, FUN:1) is used by multiple
> device drivers, if it's hidden by some device driver(e.g. i801 I2C driver,
> the commit <942469303> unconditionally hides the P2SB PCI device wrongly)
This is not how we quote commits in commit messages. Rather like this:
9424693035a5 ("i2c: i801: Create iTCO device on newer Intel PCHs")
You can add
[alias]
one = show -s --pretty='format:%h (\"%s\")'
to your .gitconfig so that when you do:
$ git one 9424693035a5
you get the proper format. You'll also need
[core]
abbrev = 12
so that the commit hash is abbreviated to 12 chars.
I fixed it up now but pls do it properly next time.
Thanks.
next reply other threads:[~2017-08-19 8:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-19 8:53 Borislav Petkov [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-08-20 2:18 [2/3] EDAC, pnd2: Conditionally unhide/hide the P2SB PCI device to read BAR Qiuxu Zhuo
2017-08-14 15:48 Qiuxu Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170819085334.kafuayddf2ymum55@pd.tnic \
--to=bp@alien8.de \
--cc=arozansk@redhat.com \
--cc=linux-edac@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=patrickg@supermicro.com \
--cc=qiuxu.zhuo@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox