From: Borislav Petkov <bp@alien8.de>
To: linux-edac <linux-edac@vger.kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Tony Luck <tony.luck@intel.com>,
Yazen Ghannam <Yazen.Ghannam@amd.com>, X86 ML <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: [0/7] EDAC, mce_amd: Issue decoded MCE through the tracepoint
Date: Mon, 28 Aug 2017 15:45:49 +0200 [thread overview]
Message-ID: <20170828134549.wh6toneoca47ff2w@pd.tnic> (raw)
On Fri, Aug 25, 2017 at 12:24:04PM +0200, Borislav Petkov wrote:
> Next step is adding that to rasdaemon.
Ok, below is the dirty version of the changes that need to go into
rasdaemon, I'll clean that up later. With it, I get:
# ./rasdaemon -f
overriding event (541) ras:mc_event with new print handler
rasdaemon: ras:mc_event event enabled
rasdaemon: Enabled event ras:mc_event
overriding event (58) mce:mce_record with new print handler
rasdaemon: mce:mce_record event enabled
rasdaemon: Enabled event mce:mce_record
overriding event (542) ras:extlog_mem_event with new print handler
rasdaemon: ras:extlog_mem_event event enabled
rasdaemon: Enabled event ras:extlog_mem_event
rasdaemon: Listening to events for cpus 0 to 7
cpu 07: <...>-104 [1433913776] 0.000006: mce_record: 2017-08-28 17:41:01 +0200 bank=4, status= 9c7d410092080813, MC4 Error (node 2): DRAM ECC error detected on the NB.
, cpu_type= generic CPU, cpu= 2, socketid= 0, misc= 0, addr= 6d3d483b, , apicid= 0
and looking at it now, I don't need that "MC%d Error..:" thing either.
All queued for the next version.
diff --git a/ras-mce-handler.c b/ras-mce-handler.c
index 2e520d3663ac..ff6f4b373e56 100644
--- a/ras-mce-handler.c
+++ b/ras-mce-handler.c
@@ -23,6 +23,7 @@
#include <unistd.h>
#include <stdint.h>
#include "libtrace/kbuffer.h"
+#include "libtrace/event-utils.h"
#include "ras-mce-handler.h"
#include "ras-record.h"
#include "ras-logger.h"
@@ -185,6 +186,10 @@ static int detect_cpu(struct ras_events *ras)
ret = 0;
if (!strcmp(mce->vendor, "AuthenticAMD")) {
+
+ ret = 0;
+ goto ret;
+
if (mce->family == 15)
mce->cputype = CPU_K8;
if (mce->family > 15) {
@@ -357,8 +362,9 @@ int ras_mce_event_handler(struct trace_seq *s,
unsigned long long val;
struct ras_events *ras = context;
struct mce_priv *mce = ras->mce_priv;
+ const char *decoded_mce;
struct mce_event e;
- int rc = 0;
+ int rc = 0, len;
memset(&e, 0, sizeof(e));
@@ -422,6 +428,10 @@ int ras_mce_event_handler(struct trace_seq *s,
if (rc)
return rc;
+ decoded_mce = pevent_get_field_raw(s, event, "decoded_str", record, &len, 1);
+ if (decoded_mce)
+ strncpy(e.error_msg, decoded_mce, min(len, 4096));
+
if (!*e.error_msg && *e.mcastatus_msg)
mce_snprintf(e.error_msg, "%s", e.mcastatus_msg);
next reply other threads:[~2017-08-28 13:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 13:45 Borislav Petkov [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-08-30 11:48 [0/7] EDAC, mce_amd: Issue decoded MCE through the tracepoint Borislav Petkov
2017-08-30 21:47 mark gross
2017-08-30 22:02 Borislav Petkov
2017-08-30 23:30 Steven Rostedt
2017-08-31 19:17 Borislav Petkov
2017-09-03 23:37 mark gross
2017-09-04 10:47 Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170828134549.wh6toneoca47ff2w@pd.tnic \
--to=bp@alien8.de \
--cc=Yazen.Ghannam@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox