* Seen "Internal error: Can't find EDAC structure"?
@ 2018-04-20 19:19 Boris Petkov
0 siblings, 0 replies; 3+ messages in thread
From: Boris Petkov @ 2018-04-20 19:19 UTC (permalink / raw)
To: Luck, Tony; +Cc: alex_gagniuc, austin_bolen, james.morse, linux-edac
On Fri, Apr 20, 2018 at 11:20:15AM -0700, Luck, Tony wrote:
> Ideas?
Does that help?
diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c
index 68b6ee18bea6..4a9231993699 100644
--- a/drivers/edac/ghes_edac.c
+++ b/drivers/edac/ghes_edac.c
@@ -439,7 +439,7 @@ int ghes_edac_register(struct ghes *ghes, struct device *dev)
/* Check if safe to enable on this system */
idx = acpi_match_platform_list(plat_list);
if (!force_load && idx < 0)
- return 0;
+ return -ENODEV;
/*
* We have only one logical memory controller to which all DIMMs belong.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Seen "Internal error: Can't find EDAC structure"?
@ 2018-04-20 20:49 Luck, Tony
0 siblings, 0 replies; 3+ messages in thread
From: Luck, Tony @ 2018-04-20 20:49 UTC (permalink / raw)
To: Borislav Petkov; +Cc: alex_gagniuc, austin_bolen, james.morse, linux-edac
On Fri, Apr 20, 2018 at 09:19:28PM +0200, Borislav Petkov wrote:
> On Fri, Apr 20, 2018 at 11:20:15AM -0700, Luck, Tony wrote:
> > Ideas?
>
> Does that help?
>
> ---
> diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c
> index 68b6ee18bea6..4a9231993699 100644
> --- a/drivers/edac/ghes_edac.c
> +++ b/drivers/edac/ghes_edac.c
> @@ -439,7 +439,7 @@ int ghes_edac_register(struct ghes *ghes, struct device *dev)
> /* Check if safe to enable on this system */
> idx = acpi_match_platform_list(plat_list);
> if (!force_load && idx < 0)
> - return 0;
> + return -ENODEV;
>
> /*
> * We have only one logical memory controller to which all DIMMs belong.
>
> --
It will be a while before I can run an actual test on the
machine where this was found. But since it isn't an HPE Server,
I'm going to branch predict that this fix will work. Looks like
this patch should be marked for stable to backport to v4.15 and v4.16
Reviewed-by: Tony Luck <tony.luck@intel.com>
-Tony
---
To unsubscribe from this list: send the line "unsubscribe linux-edac" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Seen "Internal error: Can't find EDAC structure"?
@ 2018-04-20 21:06 Boris Petkov
0 siblings, 0 replies; 3+ messages in thread
From: Boris Petkov @ 2018-04-20 21:06 UTC (permalink / raw)
To: Luck, Tony; +Cc: alex_gagniuc, austin_bolen, james.morse, linux-edac
On Fri, Apr 20, 2018 at 01:49:05PM -0700, Luck, Tony wrote:
> It will be a while before I can run an actual test on the
> machine where this was found. But since it isn't an HPE Server,
> I'm going to branch predict that this fix will work.
Hahah, I'll wait until you execute this non-speculatively, though,
considering the amount of speculation bugs out there. :-)
> Looks like
> this patch should be marked for stable to backport to v4.15 and v4.16
>
> Reviewed-by: Tony Luck <tony.luck@intel.com>
Ok.
Thx.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-20 21:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-20 19:19 Seen "Internal error: Can't find EDAC structure"? Boris Petkov
-- strict thread matches above, loose matches on Subject: below --
2018-04-20 20:49 Luck, Tony
2018-04-20 21:06 Boris Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).