Linux EDAC development
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: linux-edac@vger.kernel.org
Cc: Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@suse.de>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: EDAC, skx_edac: Express dependency to NFIT
Date: Mon, 14 May 2018 10:14:07 +0200	[thread overview]
Message-ID: <20180514101407.0a32ea6d@endymion> (raw)

If ACPI_NFIT is enabled, we must depend on it, otherwise if skx_edac
is built into the kernel, it may try to use nfit_get_smbios_id from
modular nfit and linking will break.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Fixes: 58ca9ac1463d ("EDAC, skx_edac: Detect non-volatile DIMMs")
Reported-by: kbuild test robot <lkp@intel.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 drivers/edac/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-4.17-rc4.orig/drivers/edac/Kconfig	2018-04-23 04:20:09.000000000 +0200
+++ linux-4.17-rc4/drivers/edac/Kconfig	2018-05-14 10:03:25.634772874 +0200
@@ -232,6 +232,7 @@ config EDAC_SBRIDGE
 config EDAC_SKX
 	tristate "Intel Skylake server Integrated MC"
 	depends on PCI && X86_64 && X86_MCE_INTEL && PCI_MMCONFIG
+	depends on ACPI_NFIT=n || ACPI_NFIT
 	select DMI
 	help
 	  Support for error detection and correction the Intel

                 reply	other threads:[~2018-05-14  8:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180514101407.0a32ea6d@endymion \
    --to=jdelvare@suse.de \
    --cc=bp@suse.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox