From: Pavel Machek <pavel@ucw.cz>
To: Borislav Petkov <bp@alien8.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Pu Wen <puwen@hygon.cn>,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, thomas.lendacky@amd.com, mchehab@kernel.org,
mikhail.jin@gmail.com, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, linux-edac@vger.kernel.org
Subject: [v4,15/16] driver/edac: enable Hygon support to AMD64 EDAC driver
Date: Tue, 21 Aug 2018 20:07:43 +0200 [thread overview]
Message-ID: <20180821180743.GA14431@atrey.karlin.mff.cuni.cz> (raw)
> On Tue, Aug 21, 2018 at 01:26:13PM +0200, Paolo Bonzini wrote:
> > But then I don't see the point of adding the Hygon vendor, since any
> > check can be simplified:
>
> I think Hygon wanted to superficially show it is not really an AMD. For
> example, the Hygon thing doesn't do SME/SEV. AFAIK.
>
> So we can just as well check only family but I'd say the vendor thing is
> laying the grounds for the future where reportedly it will differ more
> from an AMD. And then we can start splitting code more based on vendor
> and not look at family at all.
>
> But for right now I think we should strive to keep the changes as small
> as possible and only do real splitting when they start adding new
> functionality. Which would mean having a hygon_edac.c too, for example.
>
> All, IMHO, of course. Sharing code between vendors is always yucky.
Dunno, people do not know that 0x18 is reserved on AMD, so resulting
code is quite confusing.
Explicit vendor check is way to go, long term.
Pavel
next reply other threads:[~2018-08-21 18:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 18:07 Pavel Machek [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-08-23 8:27 [v4,15/16] driver/edac: enable Hygon support to AMD64 EDAC driver Borislav Petkov
2018-08-22 13:18 Pu Wen
2018-08-22 13:07 Pu Wen
2018-08-21 13:04 Borislav Petkov
2018-08-21 11:26 Paolo Bonzini
2018-08-21 11:20 Borislav Petkov
2018-08-21 11:04 Pu Wen
2018-08-21 8:13 Borislav Petkov
2018-08-19 16:14 Pu Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180821180743.GA14431@atrey.karlin.mff.cuni.cz \
--to=pavel@ucw.cz \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mikhail.jin@gmail.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=puwen@hygon.cn \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).