From: Borislav Petkov <bp@alien8.de>
To: "Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>
Cc: "Luck, Tony" <tony.luck@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Aristeu Rozanski <aris@redhat.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
Subject: [3/3] EDAC, sb_edac: Fix reporting wrong DIMM when patrol scrubber finds error
Date: Thu, 6 Sep 2018 14:34:52 +0200 [thread overview]
Message-ID: <20180906123452.GG10768@zn.tnic> (raw)
On Thu, Sep 06, 2018 at 11:48:00AM +0000, Zhuo, Qiuxu wrote:
> The sb_edac EDAC driver this patches fix for.
I know which driver! Your commit message formulation needs fixing.
> Sorry for the ambiguity. "ha" is the acronym for "Home Agent" that is a hardware component interfaces with cache and directly
> with its owner iMC (Integrated Memory Controller). We use the property that the index of "ha" equals to iMC's.
>
> Quoted from below datasheet section 5 (here "Bbox" is home agent, and "Mbox" is iMC):
> "The Bboxes receive Home channel request and snoop responses from caching agents, and provides
> data response and completion to the system via Bbox to Router connection. Read and write commands
> to memory go out of the Bbox to the Memory Controller (MBox)."
> https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/xeon-e7-8800-4800-2800-families-vol-2-datasheet.pdf
>
> And there is also block diagram Figure 5-1 there, hope it's useful for understanding.
Now take the gist of all that knowledge and synthesize in a proper
comment above it, *shortly* explaining what this function does.
> > You need to check the get_ha pointer before calling it because KNIGHTS_LANDING assigns NULL to it.
>
> There is already a check whether it's KNIGHT_LANDING case before calling "get_memory_error_data_from_mce() -> get_ha()".
Regardless, pls add that check anyway in case someone adds new CPU
support and forgets to add that function.
Thx.
next reply other threads:[~2018-09-06 12:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 12:34 Borislav Petkov [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-09-06 13:12 [3/3] EDAC, sb_edac: Fix reporting wrong DIMM when patrol scrubber finds error Qiuxu Zhuo
2018-09-06 11:48 Qiuxu Zhuo
2018-09-06 10:53 Borislav Petkov
2018-09-04 21:07 Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180906123452.GG10768@zn.tnic \
--to=bp@alien8.de \
--cc=aris@redhat.com \
--cc=linux-edac@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=qiuxu.zhuo@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox