Linux EDAC development
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Tony Luck <tony.luck@intel.com>
Cc: Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
	Aristeu Rozanski <aris@redhat.com>,
	Mauro Carvalho Chehab <mchehab@s-opensource.com>,
	linux-edac@vger.kernel.org
Subject: EDAC, i7core/sb_edac/skx_edac: Fix uncorrected error counting
Date: Sat, 29 Sep 2018 11:03:04 +0200	[thread overview]
Message-ID: <20180929090304.GD11115@zn.tnic> (raw)

On Fri, Sep 28, 2018 at 02:39:34PM -0700, Tony Luck wrote:
> We pick up the count of errors from bits 52:38 of the machine
> check bank status register. But this is the count of *corrected*
> errors. If we are logging an uncorrected error, the h/w set this
> field to 0. Which means that when we call into edac_mc_handle_error()
> the EDAC core will carefully add zero to the appropriate uncorrected
> error counts.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
> 
> So I was digging around in /sys/devices/system/edac/mc/mc*/* and noticed
> the the "ue_count" files all read "0" even after injecting and recovering
> from some 2-bit error.
> 
>  drivers/edac/i7core_edac.c | 1 +
>  drivers/edac/sb_edac.c     | 1 +
>  drivers/edac/skx_edac.c    | 1 +
>  3 files changed, 3 insertions(+)

Applied, thanks.

             reply	other threads:[~2018-09-29  9:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-29  9:03 Borislav Petkov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-09-28 21:39 EDAC, i7core/sb_edac/skx_edac: Fix uncorrected error counting Luck, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180929090304.GD11115@zn.tnic \
    --to=bp@alien8.de \
    --cc=aris@redhat.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=mchehab@s-opensource.com \
    --cc=qiuxu.zhuo@intel.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox