From: Borislav Petkov <bp@alien8.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
qiuxu.zhuo@intel.com, aris@redhat.com, mchehab@s-opensource.com,
"open list:EDAC-CORE" <linux-edac@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: [v3,1/3] ACPI / adxl: Add address translation interface using ACPI DSM
Date: Wed, 31 Oct 2018 19:16:33 +0100 [thread overview]
Message-ID: <20181031181633.GN15955@zn.tnic> (raw)
On Wed, Oct 31, 2018 at 11:08:01AM -0700, Luck, Tony wrote:
> It's not exactly ideal to build the skx_edac.c driver with these
> stubs. Sure, it make the kernel link without errors. But now you
> silently end up with a driver that doesn't really do all you want
> it to do.
>
> Perhaps this isn't a huge issue. Only "randconfig" would try to
> build a kernel without ACPI. The user will find other stuff is
> broken in an ACPI=n kernel long before they notice the lack of
> EDAC error reporting.
Exactly!
> So:
>
> Acked-by: Tony Luck <tony.luck@intel.com>
Thx. I'll add it to the lineup for Linus.
> Oops. Return from this isn't "bool". Caller expects 0 = success.
>
> > +static inline int adxl_decode(u64 addr, u64 component_values[]) { return false; }
>
> This should return -EOPNOTSUPP;
Done.
Thx.
next reply other threads:[~2018-10-31 18:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 18:16 Borislav Petkov [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-10-31 18:12 [v3,1/3] ACPI / adxl: Add address translation interface using ACPI DSM Luck, Tony
2018-10-31 18:08 Luck, Tony
2018-10-31 18:00 Borislav Petkov
2018-10-15 15:07 Luck, Tony
2018-10-15 7:38 Rafael J. Wysocki
2018-10-12 18:01 Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031181633.GN15955@zn.tnic \
--to=bp@alien8.de \
--cc=aris@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=mchehab@s-opensource.com \
--cc=qiuxu.zhuo@intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox