From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>,
Borislav Petkov <bp@alien8.de>,
jlu@pengutronix.de, Gregory CLEMENT <gregory.clement@bootlin.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
DTML <devicetree@vger.kernel.org>,
linux-edac@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: [v6,5/9] dt-bindings: ARM: document marvell,ecc-enable binding
Date: Fri, 9 Nov 2018 11:48:19 +0000 [thread overview]
Message-ID: <20181109114818.GB30658@n2100.armlinux.org.uk> (raw)
On Fri, Nov 09, 2018 at 12:40:06PM +0100, Arnd Bergmann wrote:
> On Fri, Nov 9, 2018 at 8:04 AM Chris Packham
> <chris.packham@alliedtelesis.co.nz> wrote:
> >
> > Add documentation for the marvell,ecc-enable and marvell,ecc-disable
> > properties which can be used to enable/disable ECC on the Marvell aurora
> > cache.
> >
> > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> > ---
>
> Why do you need both enable and disable? Wouldn't one of them be enough here?
It isn't an "on when ecc-enable is present, off when not" because the
current behaviour is to preserve these bits in the control register.
If we were to implement it as "if no ecc-enable property, turn off
ECC" then that would drastically change the behaviour - systems which
were configured for ECC suddenly lose ECC support.
Since we don't know which have it and which don't, we can't implement
the option like that.
next reply other threads:[~2018-11-09 11:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 11:48 Russell King - ARM Linux [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-11-11 22:35 [v6,5/9] dt-bindings: ARM: document marvell,ecc-enable binding Rob Herring
2018-11-11 19:57 Chris Packham
2018-11-09 15:58 Arnd Bergmann
2018-11-09 11:40 Arnd Bergmann
2018-11-09 7:03 Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181109114818.GB30658@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=jlu@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox