From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: edac: no need to check return value of debugfs_create functions From: Greg Kroah-Hartman Message-Id: <20190122152151.16139-17-gregkh@linuxfoundation.org> Date: Tue, 22 Jan 2019 16:21:16 +0100 To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Borislav Petkov , Mauro Carvalho Chehab , linux-edac@vger.kernel.org List-ID: V2hlbiBjYWxsaW5nIGRlYnVnZnMgZnVuY3Rpb25zLCB0aGVyZSBpcyBubyBuZWVkIHRvIGV2ZXIg Y2hlY2sgdGhlCnJldHVybiB2YWx1ZS4gIFRoZSBmdW5jdGlvbiBjYW4gd29yayBvciBub3QsIGJ1 dCB0aGUgY29kZSBsb2dpYyBzaG91bGQKbmV2ZXIgZG8gc29tZXRoaW5nIGRpZmZlcmVudCBiYXNl ZCBvbiB0aGlzLgoKQ2M6IEJvcmlzbGF2IFBldGtvdiA8YnBAYWxpZW44LmRlPgpDYzogTWF1cm8g Q2FydmFsaG8gQ2hlaGFiIDxtY2hlaGFiQGtlcm5lbC5vcmc+CkNjOiBsaW51eC1lZGFjQHZnZXIu a2VybmVsLm9yZwpTaWduZWQtb2ZmLWJ5OiBHcmVnIEtyb2FoLUhhcnRtYW4gPGdyZWdraEBsaW51 eGZvdW5kYXRpb24ub3JnPgotLS0KIGRyaXZlcnMvZWRhYy9kZWJ1Z2ZzLmMgICAgIHwgNDUgKysr KysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIGRyaXZlcnMvZWRhYy9lZGFjX21v ZHVsZS5oIHwgIDQgKystLQogMiBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAzNiBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2VkYWMvZGVidWdmcy5jIGIvZHJpdmVy cy9lZGFjL2RlYnVnZnMuYwppbmRleCA5MmRiYjdlMjMyMGMuLmZkMjdlYTA0NTNhMyAxMDA2NDQK LS0tIGEvZHJpdmVycy9lZGFjL2RlYnVnZnMuYworKysgYi9kcml2ZXJzL2VkYWMvZGVidWdmcy5j CkBAIC00NCwxMCArNDQsNiBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGZpbGVfb3BlcmF0aW9ucyBk ZWJ1Z19mYWtlX2luamVjdF9mb3BzID0gewogaW50IF9faW5pdCBlZGFjX2RlYnVnZnNfaW5pdCh2 b2lkKQogewogCWVkYWNfZGVidWdmcyA9IGRlYnVnZnNfY3JlYXRlX2RpcigiZWRhYyIsIE5VTEwp OwotCWlmIChJU19FUlIoZWRhY19kZWJ1Z2ZzKSkgewotCQllZGFjX2RlYnVnZnMgPSBOVUxMOwot CQlyZXR1cm4gLUVOT01FTTsKLQl9CiAJcmV0dXJuIDA7CiB9CiAKQEAgLTU2LDUwICs1MiwzMSBA QCB2b2lkIGVkYWNfZGVidWdmc19leGl0KHZvaWQpCiAJZGVidWdmc19yZW1vdmVfcmVjdXJzaXZl KGVkYWNfZGVidWdmcyk7CiB9CiAKLWludCBlZGFjX2NyZWF0ZV9kZWJ1Z2ZzX25vZGVzKHN0cnVj dCBtZW1fY3RsX2luZm8gKm1jaSkKK3ZvaWQgZWRhY19jcmVhdGVfZGVidWdmc19ub2RlcyhzdHJ1 Y3QgbWVtX2N0bF9pbmZvICptY2kpCiB7Ci0Jc3RydWN0IGRlbnRyeSAqZCwgKnBhcmVudDsKKwlz dHJ1Y3QgZGVudHJ5ICpwYXJlbnQ7CiAJY2hhciBuYW1lWzgwXTsKIAlpbnQgaTsKIAotCWlmICgh ZWRhY19kZWJ1Z2ZzKQotCQlyZXR1cm4gLUVOT0RFVjsKLQotCWQgPSBkZWJ1Z2ZzX2NyZWF0ZV9k aXIobWNpLT5kZXYua29iai5uYW1lLCBlZGFjX2RlYnVnZnMpOwotCWlmICghZCkKLQkJcmV0dXJu IC1FTk9NRU07Ci0JcGFyZW50ID0gZDsKKwlwYXJlbnQgPSBkZWJ1Z2ZzX2NyZWF0ZV9kaXIobWNp LT5kZXYua29iai5uYW1lLCBlZGFjX2RlYnVnZnMpOwogCiAJZm9yIChpID0gMDsgaSA8IG1jaS0+ bl9sYXllcnM7IGkrKykgewogCQlzcHJpbnRmKG5hbWUsICJmYWtlX2luamVjdF8lcyIsCiAJCQkg ICAgIGVkYWNfbGF5ZXJfbmFtZVttY2ktPmxheWVyc1tpXS50eXBlXSk7Ci0JCWQgPSBkZWJ1Z2Zz X2NyZWF0ZV91OChuYW1lLCBTX0lSVUdPIHwgU19JV1VTUiwgcGFyZW50LAotCQkJCSAgICAgICZt Y2ktPmZha2VfaW5qZWN0X2xheWVyW2ldKTsKLQkJaWYgKCFkKQotCQkJZ290byBub21lbTsKKwkJ ZGVidWdmc19jcmVhdGVfdTgobmFtZSwgU19JUlVHTyB8IFNfSVdVU1IsIHBhcmVudCwKKwkJCQkg ICZtY2ktPmZha2VfaW5qZWN0X2xheWVyW2ldKTsKIAl9CiAKLQlkID0gZGVidWdmc19jcmVhdGVf Ym9vbCgiZmFrZV9pbmplY3RfdWUiLCBTX0lSVUdPIHwgU19JV1VTUiwgcGFyZW50LAotCQkJCSZt Y2ktPmZha2VfaW5qZWN0X3VlKTsKLQlpZiAoIWQpCi0JCWdvdG8gbm9tZW07CisJZGVidWdmc19j cmVhdGVfYm9vbCgiZmFrZV9pbmplY3RfdWUiLCBTX0lSVUdPIHwgU19JV1VTUiwgcGFyZW50LAor CQkJICAgICZtY2ktPmZha2VfaW5qZWN0X3VlKTsKIAotCWQgPSBkZWJ1Z2ZzX2NyZWF0ZV91MTYo ImZha2VfaW5qZWN0X2NvdW50IiwgU19JUlVHTyB8IFNfSVdVU1IsIHBhcmVudCwKLQkJCQkmbWNp LT5mYWtlX2luamVjdF9jb3VudCk7Ci0JaWYgKCFkKQotCQlnb3RvIG5vbWVtOworCWRlYnVnZnNf Y3JlYXRlX3UxNigiZmFrZV9pbmplY3RfY291bnQiLCBTX0lSVUdPIHwgU19JV1VTUiwgcGFyZW50 LAorCQkJICAgJm1jaS0+ZmFrZV9pbmplY3RfY291bnQpOwogCi0JZCA9IGRlYnVnZnNfY3JlYXRl X2ZpbGUoImZha2VfaW5qZWN0IiwgU19JV1VTUiwgcGFyZW50LAotCQkJCSZtY2ktPmRldiwKLQkJ CQkmZGVidWdfZmFrZV9pbmplY3RfZm9wcyk7Ci0JaWYgKCFkKQotCQlnb3RvIG5vbWVtOworCWRl YnVnZnNfY3JlYXRlX2ZpbGUoImZha2VfaW5qZWN0IiwgU19JV1VTUiwgcGFyZW50LCAmbWNpLT5k ZXYsCisJCQkgICAgJmRlYnVnX2Zha2VfaW5qZWN0X2ZvcHMpOwogCiAJbWNpLT5kZWJ1Z2ZzID0g cGFyZW50OwotCXJldHVybiAwOwotbm9tZW06Ci0JZWRhY19kZWJ1Z2ZzX3JlbW92ZV9yZWN1cnNp dmUobWNpLT5kZWJ1Z2ZzKTsKLQlyZXR1cm4gLUVOT01FTTsKIH0KIAogLyogQ3JlYXRlIGEgdG9w bGV2ZWwgZGlyIHVuZGVyIEVEQUMncyBkZWJ1Z2ZzIGhpZXJhcmNoeSAqLwpkaWZmIC0tZ2l0IGEv ZHJpdmVycy9lZGFjL2VkYWNfbW9kdWxlLmggYi9kcml2ZXJzL2VkYWMvZWRhY19tb2R1bGUuaApp bmRleCBkZWM4OGRjZWEwMzYuLmJjNjNhNmE5ZGQwYSAxMDA2NDQKLS0tIGEvZHJpdmVycy9lZGFj L2VkYWNfbW9kdWxlLmgKKysrIGIvZHJpdmVycy9lZGFjL2VkYWNfbW9kdWxlLmgKQEAgLTcxLDcg KzcxLDcgQEAgZXh0ZXJuIHZvaWQgKmVkYWNfYWxpZ25fcHRyKHZvaWQgKipwLCB1bnNpZ25lZCBz aXplLCBpbnQgbl9lbGVtcyk7CiAjaWZkZWYgQ09ORklHX0VEQUNfREVCVUcKIGludCBlZGFjX2Rl YnVnZnNfaW5pdCh2b2lkKTsKIHZvaWQgZWRhY19kZWJ1Z2ZzX2V4aXQodm9pZCk7Ci1pbnQgZWRh Y19jcmVhdGVfZGVidWdmc19ub2RlcyhzdHJ1Y3QgbWVtX2N0bF9pbmZvICptY2kpOwordm9pZCBl ZGFjX2NyZWF0ZV9kZWJ1Z2ZzX25vZGVzKHN0cnVjdCBtZW1fY3RsX2luZm8gKm1jaSk7CiBzdHJ1 Y3QgZGVudHJ5ICplZGFjX2RlYnVnZnNfY3JlYXRlX2Rpcihjb25zdCBjaGFyICpkaXJuYW1lKTsK IHN0cnVjdCBkZW50cnkgKgogZWRhY19kZWJ1Z2ZzX2NyZWF0ZV9kaXJfYXQoY29uc3QgY2hhciAq ZGlybmFtZSwgc3RydWN0IGRlbnRyeSAqcGFyZW50KTsKQEAgLTg1LDcgKzg1LDcgQEAgZWRhY19k ZWJ1Z2ZzX2NyZWF0ZV94MTYoY29uc3QgY2hhciAqbmFtZSwgdW1vZGVfdCBtb2RlLCBzdHJ1Y3Qg ZGVudHJ5ICpwYXJlbnQsIHUKICNlbHNlCiBzdGF0aWMgaW5saW5lIGludCBlZGFjX2RlYnVnZnNf aW5pdCh2b2lkKQkJCQkJeyByZXR1cm4gLUVOT0RFVjsgfQogc3RhdGljIGlubGluZSB2b2lkIGVk YWNfZGVidWdmc19leGl0KHZvaWQpCQkJCQl7IH0KLXN0YXRpYyBpbmxpbmUgaW50IGVkYWNfY3Jl YXRlX2RlYnVnZnNfbm9kZXMoc3RydWN0IG1lbV9jdGxfaW5mbyAqbWNpKQkJeyByZXR1cm4gMDsg fQorc3RhdGljIGlubGluZSB2b2lkIGVkYWNfY3JlYXRlX2RlYnVnZnNfbm9kZXMoc3RydWN0IG1l bV9jdGxfaW5mbyAqbWNpKQkJeyB9CiBzdGF0aWMgaW5saW5lIHN0cnVjdCBkZW50cnkgKmVkYWNf ZGVidWdmc19jcmVhdGVfZGlyKGNvbnN0IGNoYXIgKmRpcm5hbWUpCXsgcmV0dXJuIE5VTEw7IH0K IHN0YXRpYyBpbmxpbmUgc3RydWN0IGRlbnRyeSAqCiBlZGFjX2RlYnVnZnNfY3JlYXRlX2Rpcl9h dChjb25zdCBjaGFyICpkaXJuYW1lLCBzdHJ1Y3QgZGVudHJ5ICpwYXJlbnQpCQl7IHJldHVybiBO VUxMOyB9Cg==