From: Borislav Petkov <bp@alien8.de>
To: Tony Luck <tony.luck@intel.com>
Cc: Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
Aristeu Rozanski <aris@redhat.com>,
Mauro Carvalho Chehab <mchehab@s-opensource.com>,
Kan Liang <kan.liang@linux.intel.com>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [1/4] EDAC, skx_comm_edac: Separate common codes from the skx_edac driver
Date: Tue, 29 Jan 2019 17:09:28 +0100 [thread overview]
Message-ID: <20190129160928.GB27037@zn.tnic> (raw)
On Fri, Jan 25, 2019 at 11:58:59AM -0800, Tony Luck wrote:
> From: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
>
> Part of the skx_edac driver codes are also used for Intel 10nm server
> EDAC driver. Carve out the common part from the skx_edac driver in
> preparation to support both skx_edac driver and i10nm_edac driver.
>
> Co-developed-by: Tony Luck <tony.luck@intel.com>
> Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
> drivers/edac/skx_comm_edac.c | 693 +++++++++++++++++++++++++++++++++++
> drivers/edac/skx_comm_edac.h | 158 ++++++++
> 2 files changed, 851 insertions(+)
> create mode 100644 drivers/edac/skx_comm_edac.c
> create mode 100644 drivers/edac/skx_comm_edac.h
skx_common.[ch]
> diff --git a/drivers/edac/skx_comm_edac.h b/drivers/edac/skx_comm_edac.h
> new file mode 100644
> index 000000000000..f7618a9cc0ae
> --- /dev/null
> +++ b/drivers/edac/skx_comm_edac.h
> @@ -0,0 +1,158 @@
> +// SPDX-License-Identifier: GPL-2.0
If you guys would've used checkpatch, you would've seen:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#739: FILE: drivers/edac/skx_comm_edac.h:1:
+// SPDX-License-Identifier: GPL-2.0
Needs to be /* ... */ in a header.
next reply other threads:[~2019-01-29 16:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 16:09 Borislav Petkov [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-01-25 19:58 [1/4] EDAC, skx_comm_edac: Separate common codes from the skx_edac driver Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129160928.GB27037@zn.tnic \
--to=bp@alien8.de \
--cc=aris@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@s-opensource.com \
--cc=qiuxu.zhuo@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox