From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [3/3] edac: sifive: Add EDAC platform driver for SiFive SoCs From: Borislav Petkov Message-Id: <20190418125015.GI27160@zn.tnic> Date: Thu, 18 Apr 2019 14:50:15 +0200 To: Yash Shah Cc: devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, palmer@sifive.com, aou@eecs.berkeley.edu, paul.walmsley@sifive.com, mchehab@kernel.org, james.morse@arm.com, sachin.ghadi@sifive.com List-ID: T24gTW9uLCBBcHIgMTUsIDIwMTkgYXQgMDU6MTA6NDNQTSArMDUzMCwgWWFzaCBTaGFoIHdyb3Rl Ogo+IFRoaXMgaW5pdGlhbCB2ZXIgb2YgRURBQyBkcml2ZXIgc3VwcG9ydHM6Cj4gLSBFQ0MgZXZl bnQgbW9uaXRvcmluZyBhbmQgcmVwb3J0aW5nIHRocm91Z2ggdGhlIEVEQUMgZnJhbWV3b3JrIGZv ciBTaUZpdmUKPiAgIEwyIGNhY2hlIGNvbnRyb2xsZXIuCj4gCj4gVGhpcyBkcml2ZXIgcmVnaXN0 ZXJzIGZvciBub3RpZmllciBldmVudHMgZnJvbSB0aGUgTDIgY2FjaGUgY29udHJvbGxlcgo+IGRy aXZlciAoYXJjaC9yaXNjdi9tbS9zaWZpdmVfbDJfY2FjaGUuYykgZm9yIEwyIEVDQyBldmVudHMK PiAKPiBTaWduZWQtb2ZmLWJ5OiBZYXNoIFNoYWggPHlhc2guc2hhaEBzaWZpdmUuY29tPgo+IC0t LQo+ICBhcmNoL3Jpc2N2L0tjb25maWcgICAgICAgICB8ICAgMSArCj4gIGRyaXZlcnMvZWRhYy9L Y29uZmlnICAgICAgIHwgICA2ICsrKwo+ICBkcml2ZXJzL2VkYWMvTWFrZWZpbGUgICAgICB8ICAg MSArCj4gIGRyaXZlcnMvZWRhYy9zaWZpdmVfZWRhYy5jIHwgMTIxICsrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICA0IGZpbGVzIGNoYW5nZWQsIDEyOSBpbnNl cnRpb25zKCspCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL2VkYWMvc2lmaXZlX2VkYWMu YwoKUGxlYXNlIGFkZCBhIE1BSU5UQUlORVJTIGVudHJ5IGxpa2UgdGhlIG90aGVyIEVEQUMgZHJp dmVycyBkbyBzbyB0aGF0CnlvdSBjYW4gZ2V0IENDZWQgb24gcGF0Y2hlcy9idWcgcmVwb3J0cy4K ClRoZSByZXN0IGxvb2tzIG9rIHRvIG1lLgoKSSdkIHN0aWxsIGxpa2UgZm9yIEphbWVzIHRvIGhh dmUgYSBsb29rIHRvbywgd2hlbiBoZSBnZXRzIHRvIGl0LgoKVGh4Lgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67BD4C10F0E for ; Thu, 18 Apr 2019 12:50:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 385DE2183F for ; Thu, 18 Apr 2019 12:50:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="kBrtG7Dr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388430AbfDRMuT (ORCPT ); Thu, 18 Apr 2019 08:50:19 -0400 Received: from mail.skyhub.de ([5.9.137.197]:47724 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388375AbfDRMuT (ORCPT ); Thu, 18 Apr 2019 08:50:19 -0400 Received: from zn.tnic (p200300EC2F112E003868EF36058F9C84.dip0.t-ipconnect.de [IPv6:2003:ec:2f11:2e00:3868:ef36:58f:9c84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id E21341EC0380; Thu, 18 Apr 2019 14:50:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1555591817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=HNUlulpvxLgueM5KwBkwZM9kUDW+7A8qOVVjx5GX6Uc=; b=kBrtG7DrmDlg8mxIQUX5owKGGclTe/MBIAH9iD2NUhLnfRQd3qUywuC2WSVxNxdiSswvBJ wiOxluTdbEuF3tWsjegvWHRIV1vL3uwrPM2YU/U/uJ7TipAiuABJ2L8cSPdjA5YOSfhhaI DNJOA+eOM7DIpkSEnXwMo7qCr+VX3N4= Date: Thu, 18 Apr 2019 14:50:15 +0200 From: Borislav Petkov To: Yash Shah Cc: devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, palmer@sifive.com, aou@eecs.berkeley.edu, paul.walmsley@sifive.com, mchehab@kernel.org, james.morse@arm.com, sachin.ghadi@sifive.com Subject: Re: [PATCH 3/3] edac: sifive: Add EDAC platform driver for SiFive SoCs Message-ID: <20190418125015.GI27160@zn.tnic> References: <1555328443-30874-1-git-send-email-yash.shah@sifive.com> <1555328443-30874-4-git-send-email-yash.shah@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <1555328443-30874-4-git-send-email-yash.shah@sifive.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org Message-ID: <20190418125015.nd7ku_KYPQMhTQw84C9CLVlf5BmvTtSyuThTP1kLvQ8@z> On Mon, Apr 15, 2019 at 05:10:43PM +0530, Yash Shah wrote: > This initial ver of EDAC driver supports: > - ECC event monitoring and reporting through the EDAC framework for SiFive > L2 cache controller. > > This driver registers for notifier events from the L2 cache controller > driver (arch/riscv/mm/sifive_l2_cache.c) for L2 ECC events > > Signed-off-by: Yash Shah > --- > arch/riscv/Kconfig | 1 + > drivers/edac/Kconfig | 6 +++ > drivers/edac/Makefile | 1 + > drivers/edac/sifive_edac.c | 121 +++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 129 insertions(+) > create mode 100644 drivers/edac/sifive_edac.c Please add a MAINTAINERS entry like the other EDAC drivers do so that you can get CCed on patches/bug reports. The rest looks ok to me. I'd still like for James to have a look too, when he gets to it. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.