From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1316BC04E84 for ; Fri, 17 May 2019 20:02:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D70902087B for ; Fri, 17 May 2019 20:02:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="olPH8CQg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727949AbfEQUCe (ORCPT ); Fri, 17 May 2019 16:02:34 -0400 Received: from mail.skyhub.de ([5.9.137.197]:52150 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727088AbfEQUCd (ORCPT ); Fri, 17 May 2019 16:02:33 -0400 Received: from zn.tnic (p200300EC2F0C500031BA4AEE98C6BAA9.dip0.t-ipconnect.de [IPv6:2003:ec:2f0c:5000:31ba:4aee:98c6:baa9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 8E2711EC01D4; Fri, 17 May 2019 22:02:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1558123351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=9VydyjHzDmof8wnmo6GNe/zh/nlLASDl1sKA6ia7xU0=; b=olPH8CQgu3OFNC55UYroNnBzifiMkR8xA3FA0NO9KU9pV4Ti599N91Rm36lL9XnkU8s//l nTD1nhHb7gqAos6TQ49q/6ttRX0Ot45ZmYx/0ReKe2LTXgQE2QRolIDdn0PuNE6YEMs8pW akjql6reFAWRRIf3aaBbY/TM7/eIC/4= Date: Fri, 17 May 2019 22:02:25 +0200 From: Borislav Petkov To: "Ghannam, Yazen" Cc: "Luck, Tony" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" Subject: Re: [PATCH v3 5/6] x86/MCE: Save MCA control bits that get set in hardware Message-ID: <20190517200225.GK13482@zn.tnic> References: <20190516203456.GD21857@zn.tnic> <20190516205943.GA3299@agluck-desk> <20190517101006.GA32065@zn.tnic> <20190517163729.GE13482@zn.tnic> <20190517172648.GA18164@agluck-desk> <20190517174817.GG13482@zn.tnic> <20190517180607.GA21710@agluck-desk> <20190517193431.GI13482@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Fri, May 17, 2019 at 07:49:10PM +0000, Ghannam, Yazen wrote: > > @@ -1569,7 +1575,13 @@ static void __mcheck_cpu_init_clear_banks(void) > > > > if (!b->init) > > continue; > > + > > + /* Check if any bits are implemented in h/w */ > > wrmsrl(msr_ops.ctl(i), b->ctl); > > + rdmsrl(msr_ops.ctl(i), msrval); > > + > > + b->init = !!msrval; > > + > Just a minor nit, but can we group the comment, RDMSR, and check > together? The WRMSR is part of normal operation and isn't tied to the > check. Of course it is - that's the "throw all 1s at it" part :) -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.