From: Borislav Petkov <bp@alien8.de>
To: luanshi <zhangliguang@linux.alibaba.com>
Cc: Tony Luck <tony.luck@intel.com>, linux-edac@vger.kernel.org
Subject: Re: [PATCH] x86/mce: Fix memleak in mce_banks
Date: Thu, 6 Jun 2019 09:50:15 +0200 [thread overview]
Message-ID: <20190606075015.GC26146@zn.tnic> (raw)
In-Reply-To: <1559804967-46320-1-git-send-email-zhangliguang@linux.alibaba.com>
On Thu, Jun 06, 2019 at 03:09:27PM +0800, luanshi wrote:
> From: zhangliguang <zhangliguang@linux.alibaba.com>
>
> The mce_banks is leaked in the error out cases during
> __mcheck_cpu_apply_quirks and mce_gen_pool_init. This patch fixes it.
Maybe my reply from last night wasn't clear so lemme repeat it again:
this patch is not needed because we're removing the kcalloc call there
and the banks will be allocated statically in the future.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
prev parent reply other threads:[~2019-06-06 7:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 7:09 [PATCH] x86/mce: Fix memleak in mce_banks luanshi
2019-06-06 7:50 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606075015.GC26146@zn.tnic \
--to=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=zhangliguang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox