From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49188C31E49 for ; Thu, 13 Jun 2019 19:18:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2063220896 for ; Thu, 13 Jun 2019 19:18:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="EECThUP9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727639AbfFMTSw (ORCPT ); Thu, 13 Jun 2019 15:18:52 -0400 Received: from mail.skyhub.de ([5.9.137.197]:48610 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725842AbfFMTSw (ORCPT ); Thu, 13 Jun 2019 15:18:52 -0400 Received: from zn.tnic (p200300EC2F06D500AC63EB441B910094.dip0.t-ipconnect.de [IPv6:2003:ec:2f06:d500:ac63:eb44:1b91:94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id EE67D1EC0985; Thu, 13 Jun 2019 21:18:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1560453531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=tGmweZyu+PJItjJOWXyB3Q5UWVPPfVhUCDHjLGlC4e8=; b=EECThUP9l5MNSE5Dx0ZCv3Gj5Hwy0Zo+VMfoVxBCfaomOnlGPCYhA/k/b4Y57U/kMX5czN /aSCgjI5GoU0S734WSVMewokbnVCNp5bHabyblgeNrZ0Ys11sx/24eWsBJoUqOMVfhPWtG QRwsT9bwsVqoxiiPcJiuTNf+ctiibf4= Date: Thu, 13 Jun 2019 21:18:43 +0200 From: Borislav Petkov To: James Morse Cc: linux-edac@vger.kernel.org, Mauro Carvalho Chehab , Robert Richter , Toshi Kani Subject: Re: [PATCH] EDAC, ghes: Fix grain calculation Message-ID: <20190613191843.GG11598@zn.tnic> References: <20190529152232.187580-1-james.morse@arm.com> <20190612043410.GE32652@zn.tnic> <9bda9613-09b3-aa6d-183f-3668ef9a99c6@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9bda9613-09b3-aa6d-183f-3668ef9a99c6@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Thu, Jun 13, 2019 at 06:06:22PM +0100, James Morse wrote: > edac_raw_mc_handle_error() prints it out, Of course it does, sorry for not seeing it. ;-\ > We could replace edac_raw_mc_handle_error()'s use of e->grain with e->grain_bits, which > would also make Robert's life easier when trying to merge those paths, but that's a more > invasive change. > > I did did it like this to make it the minimum change if it was going as a fix. If we're > confident that no-one has-noticed/cared this can be papered over as part of Robert's > series, otherwise it will conflict. Yeah, lemme take your patch as is and we can still improve on that whole flow once the dust of all that cleanup settles. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.