RE: [PATCH v3 0/8] AMD64 EDAC fixes

Ghannam, Yazen
2019-08-22T18:55:12Z

> -----Original Message-----
> From: linux-edac-owner@vger.kernel.org <linux-edac-owner@vger.kernel.org> On Behalf Of Adam Borowski
> Sent: Wednesday, August 21, 2019 7:50 PM
> To: Ghannam, Yazen <Yazen.Ghannam@amd.com>
> Cc: linux-edac@vger.kernel.org; linux-kernel@vger.kernel.org; bp@alien8.de
> Subject: Re: [PATCH v3 0/8] AMD64 EDAC fixes
>
> On Wed, Aug 21, 2019 at 11:59:53PM +0000, Ghannam, Yazen wrote:
> > I've also added RFC patches to avoid the "ECC disabled" message for
> > nodes without memory. I haven't fully tested these, but I wanted to get
> > your thoughts. Here's an earlier discussion:
> > https://lkml.kernel.org/r/20180321191335.7832-1-Yazen.Ghannam@amd.com
>
> While you're editing that code, could you please also cut the spam if ECC is
> actually disabled? For example, a 2990WX with non-ECC RAM gets 1024 lines;
> 64 copies of:
>
> [ 8.186164] EDAC amd64: Node 0: DRAM ECC disabled.
> [ 8.188364] EDAC amd64: ECC disabled in the BIOS or no ECC capability, module will not load.
> Either enable ECC checking or force module loading by setting 'ecc_enable_override'.
> (Note that use of the override may cause unknown side effects.)
> [ 8.194762] EDAC amd64: Node 1: DRAM ECC disabled.
> [ 8.196307] EDAC amd64: ECC disabled in the BIOS or no ECC capability, module will not load.
> Either enable ECC checking or force module loading by setting 'ecc_enable_override'.
> (Note that use of the override may cause unknown side effects.)
> [ 8.199840] EDAC amd64: Node 2: DRAM ECC disabled.
> [ 8.200963] EDAC amd64: ECC disabled in the BIOS or no ECC capability, module will not load.
> Either enable ECC checking or force module loading by setting 'ecc_enable_override'.
> (Note that use of the override may cause unknown side effects.)
> [ 8.204326] EDAC amd64: Node 3: DRAM ECC disabled.
> [ 8.205436] EDAC amd64: ECC disabled in the BIOS or no ECC capability, module will not load.
> Either enable ECC checking or force module loading by setting 'ecc_enable_override'.
> (Note that use of the override may cause unknown side effects.)
>

I wonder if the module is being loaded multiple times. I'll try to reproduce this and track it down.

Thanks for testing and reporting this issue.

-Yazen